Page MenuHomeFreeBSD
Differential D25899

graphics/webp-pixbuf-loader: Update to 0.0.1 -> stage_fs_violation
ClosedPublic
Actions

Authored by rigoletto on Jul 31 2020, 1:32 AM.
Tags
None
Referenced Files
F103678058: D25899.id75257.diff
Wed, Nov 27, 10:41 PM
F103678056: D25899.id75219.diff
Wed, Nov 27, 10:41 PM
F103678054: D25899.id75194.diff
Wed, Nov 27, 10:40 PM
F103678051: D25899.id75223.diff
Wed, Nov 27, 10:40 PM
F103678050: D25899.id75203.diff
Wed, Nov 27, 10:40 PM
F103678046: D25899.id75241.diff
Wed, Nov 27, 10:40 PM
F103677759: D25899.id75193.diff
Wed, Nov 27, 10:35 PM
F103677755: D25899.id75192.diff
Wed, Nov 27, 10:35 PM
View All Files
Subscribers
mat

Details

Reviewers
kwm
val_packett.cool
Commits
rP543923: graphics/webp-pixbuf-loader: Update to 0.0.1
Summary
  • the port seems abbandoned
  • unfortunatelly there is a need to use PORTEPOCH (I would like to avoid if possible)
  • poudriere rise stage_fs_violation, and I have no clue of why
=>> Checking for staging violations... done
=>> Error: Filesystem touched during stage (files must install to ${STAGEDIR}):
usr/local/lib/gdk-pixbuf-2.0/2.10.0/loaders.cache: 
	size (2841, 2840)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 32690
Build 30139: arc lint + arc unit

Event Timeline

rigoletto created this revision.Jul 31 2020, 1:32 AM
Herald added a subscriber: mat. · View Herald TranscriptJul 31 2020, 1:32 AM
Harbormaster completed remote builds in B32668: Diff 75192.Jul 31 2020, 1:32 AM
rigoletto requested review of this revision.Jul 31 2020, 1:32 AM
rigoletto retitled this revision from graphics/webp-pixbuf-loader: Update to 0.0.1 -stage_fs_violation to graphics/webp-pixbuf-loader: Update to 0.0.1-stage_fs_violation.Jul 31 2020, 1:33 AM
rigoletto edited the summary of this revision. (Show Details)
rigoletto edited the summary of this revision. (Show Details)
rigoletto retitled this revision from graphics/webp-pixbuf-loader: Update to 0.0.1-stage_fs_violation to graphics/webp-pixbuf-loader: Update to 0.0.1 -> stage_fs_violation.Jul 31 2020, 1:36 AM
rigoletto updated this revision to Diff 75193.Jul 31 2020, 1:39 AM

Re-instate STRIP_CMD.

Harbormaster completed remote builds in B32669: Diff 75193.Jul 31 2020, 1:39 AM
rigoletto updated this revision to Diff 75194.Jul 31 2020, 1:41 AM

Fix STRIP_CMD path.

Harbormaster completed remote builds in B32670: Diff 75194.Jul 31 2020, 1:41 AM
val_packett.cool added a subscriber: val_packett.cool.Jul 31 2020, 10:17 AM

unfortunatelly there is a need to use PORTEPOCH

huh, why?

poudriere rise stage_fs_violation, and I have no clue of why
usr/local/lib/gdk-pixbuf-2.0/2.10.0/loaders.cache

Because the build system is doing gdk-pixbuf-query-loaders --update-cache for us, that should be disabled.
(And should be done in pkg post install hooks..)

They have a gdk_pixbuf_query_loaders_path meson option now, so we could define that to something harmless like echo.

graphics/webp-pixbuf-loader/Makefile
21–22

I'm pretty sure it should be thumbnailers, that must be a mistake.

% ls /usr/local/share/thumbnailers
evince.thumbnailer                      gdk-pixbuf-webp-thumbnailer.thumbnailer heif.thumbnailer                        mypaint-ora.thumbnailer
gdk-pixbuf-thumbnailer.thumbnailer      gsf-office.thumbnailer                  librsvg.thumbnailer                     renderdoc.thumbnailer

Raised https://github.com/aruiz/webp-pixbuf-loader/issues/19

rigoletto added a comment.Jul 31 2020, 10:34 AM

The port was not abandoned good. :-)

In D25899#573787, @greg_unrelenting.technology wrote:

unfortunatelly there is a need to use PORTEPOCH

huh, why?

20160329 > 0.0.1

When there is no version yet, please, use:

DISTVERSION=	g20160329

https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-distfiles.html#makefile-master_sites-github-description

:-D

poudriere rise stage_fs_violation, and I have no clue of why
usr/local/lib/gdk-pixbuf-2.0/2.10.0/loaders.cache

Because the build system is doing gdk-pixbuf-query-loaders --update-cache for us, that should be disabled.
(And should be done in pkg post install hooks..)

They have a gdk_pixbuf_query_loaders_path meson option now, so we could define that to something harmless like echo.

I was tough about that this night but I would need to have a look on how to do it since I am not used to gdk. Also, I have to have a look on that path but this is being done by upstream.

Thanks!

rigoletto updated this revision to Diff 75203.EditedJul 31 2020, 11:06 AM

General update.

gdk-pixbuf-query-loaders --update-cache

brought a few doubts:

  1. it needs to be run by root hence the port could not be built by user;
  2. should it use FAKEROOT?
  3. the command could theoretically be run from anywhere, does it worth to run from ${STAGEDIR} or something?

@mat

PS. the path thing was already be fixed by upstream.

Thanks!

Harbormaster completed remote builds in B32673: Diff 75203.Jul 31 2020, 11:06 AM
rigoletto marked an inline comment as done.Jul 31 2020, 11:07 AM
val_packett.cool added a comment.Jul 31 2020, 11:55 AM

No, no, please read this carefully again:

Because the build system is doing gdk-pixbuf-query-loaders --update-cache for us, that should be disabled.
(And should be done in pkg post install hooks..)

We specifically MUST NOT run gdk-pixbuf-query-loaders --update-cache at BUILD time, only at pkg install time.

Basically copy the @postexec / @postunexec lines from graphics/librsvg2-rust/pkg-plist here.

And add something like MESON_ARGS+= -Dgdk_pixbuf_query_loaders_path=/bin/echo to not do it at build time

rigoletto added a comment.EditedJul 31 2020, 12:30 PM
In D25899#573804, @greg_unrelenting.technology wrote:

No, no, please read this carefully again:

Because the build system is doing gdk-pixbuf-query-loaders --update-cache for us, that should be disabled.
(And should be done in pkg post install hooks..)

We specifically MUST NOT run gdk-pixbuf-query-loaders --update-cache at BUILD time, only at pkg install time.

Basically copy the @postexec / @postunexec lines from graphics/librsvg2-rust/pkg-plist here.

And add something like MESON_ARGS+= -Dgdk_pixbuf_query_loaders_path=/bin/echo to not do it at build time

I've commented that line out. Cleaner than doing things for no reason,

rigoletto added a reviewer: val_packett.cool.Jul 31 2020, 12:57 PM
rigoletto removed a subscriber: val_packett.cool.
val_packett.cool added inline comments.Jul 31 2020, 3:43 PM
graphics/webp-pixbuf-loader/Makefile
23–24

???

You've commented it out in meson just to do the same manually at the same time. post-install is when the ports makefile "installs" the software into the staging directory.

Basically copy the @postexec / @postunexec lines from graphics/librsvg2-rust/pkg-plist here.

We have to have a pkg-plist that would do this IN PKG.

rigoletto updated this revision to Diff 75219.Jul 31 2020, 4:54 PM

Seems to work as expected now.

Harbormaster completed remote builds in B32680: Diff 75219.Jul 31 2020, 4:54 PM
rigoletto added inline comments.Jul 31 2020, 4:59 PM
graphics/webp-pixbuf-loader/Makefile
23–24

???

You've commented it out in meson just to do the same manually at the same time. post-install is when the ports makefile "installs" the software into the staging directory.

Basically copy the @postexec / @postunexec lines from graphics/librsvg2-rust/pkg-plist here.

We have to have a pkg-plist that would do this IN PKG.

Sorry, just saw I see your comment, and I have not finished yet. :-)

rigoletto updated this revision to Diff 75221.Jul 31 2020, 5:18 PM

Well, I think this is more correct to be done at post-install phase. :-)

Harbormaster completed remote builds in B32681: Diff 75221.Jul 31 2020, 5:18 PM
rigoletto updated this revision to Diff 75223.Jul 31 2020, 5:33 PM

Add PORTEPOCH. :-(

Harbormaster completed remote builds in B32683: Diff 75223.Jul 31 2020, 5:33 PM
val_packett.cool added inline comments.Jul 31 2020, 11:25 PM
graphics/webp-pixbuf-loader/Makefile
23–24

That echo won't do anything unless you echo into TMPPLIST or PLIST whatever is appropriate for PLIST_FILES.

I'd rather switch to a real plist file.

rigoletto added inline comments.Aug 1 2020, 2:14 AM
graphics/webp-pixbuf-loader/Makefile
23–24

Hi, we can switch to a pkg-plist file but the project recommendation is to use PLIST_FILES when there are just a few files. :-)

rigoletto updated this revision to Diff 75241.Aug 1 2020, 8:31 AM

Add pkg-plist. In this particular case not using the pkg-plist file proved to be worse than using it with a few files.

Thanks for your pacience. ;-)

Harbormaster completed remote builds in B32690: Diff 75241.Aug 1 2020, 8:31 AM
rigoletto marked 2 inline comments as done.Aug 1 2020, 8:32 AM

I just still don't know why the cache was apparently being updated before but this is something I can investigate later.

val_packett.cool accepted this revision.Aug 1 2020, 8:02 PM
In D25899#574031, @rigoletto wrote:

I just still don't know why the cache was apparently being updated before but this is something I can investigate later.

Before as in..?

This revision is now accepted and ready to land.Aug 1 2020, 8:02 PM
rigoletto added a comment.Aug 1 2020, 8:58 PM
In D25899#574151, @greg_unrelenting.technology wrote:
In D25899#574031, @rigoletto wrote:

I just still don't know why the cache was apparently being updated before but this is something I can investigate later.

Before as in..?

I've run gdk-pixbuf-query-loaders --update-cache after removing the package, and I supposed it would remove it from the cache (what seems sane to me).

Closed by commit rP543923: graphics/webp-pixbuf-loader: Update to 0.0.1 (authored by rigoletto). · Explain WhyAug 1 2020, 9:16 PM
This revision was automatically updated to reflect the committed changes.
rigoletto added a commit: rP543923: graphics/webp-pixbuf-loader: Update to 0.0.1.

Revision Contents
Changeset List

PathSize
graphics/
webp-pixbuf-loader/
17 lines
6 lines
11 lines
4 lines

Diff 75241

View Options

graphics/webp-pixbuf-loader/Makefile

Loading...
View Options

graphics/webp-pixbuf-loader/distinfo

Loading...
View Options

graphics/webp-pixbuf-loader/files/

Loading...
View Options

graphics/webp-pixbuf-loader/files/patch-meson.build

Loading...
View Options

graphics/webp-pixbuf-loader/pkg-plist

Loading...