Do not mention loading modules via loader.conf It is generally discouraged to load graphics kernel modules via loder.conf(5). According to kevans@, loader.conf loading Nvidia modules is fragile for UEFI on FreeBSD <= 12.1. It might work, but those modules are large and ; the loader's staging area for insufficient to contain kernel, Nvidia modules, and much of anything else at the same time. Also, while here, encourage people to use sysrc to modify the contents of rc.conf(5).
Details
Details
- Reviewers
danfe - Commits
- rP540866: Do not mention loading modules via loader.conf
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| x11/nvidia-driver/Makefile | ||
|---|---|---|
| 16 ↗ | (On Diff #73873) | Actually, I'll probably need to bump PORTREVISION for those other nvidia-driver-* ports as well. |
| x11/nvidia-driver/files/pkg-message.in | ||
|---|---|---|
| 7 ↗ | (On Diff #73874) | Hmm, I've removed # here so that the comments align nicely when indenting with tabs BTW. Let me know if you like it or not :) |
Comment Actions
I'm accepting it proactively (even though I've suggested one what seems to me as an improvement, I'm fine if you prefer your original version and won't argue over it), thanks!
| x11/nvidia-driver/files/pkg-message.in | ||
|---|---|---|
| 7 ↗ | (On Diff #73874) | My initial reaction was "well it supposed to show that these comments require superuser privileges" but given your explanation (I'm also a big fan when things align nicely) I'm fine with dropping the root prompt. Just make sure you indent with tab(s), not spaces. |
| 10 ↗ | (On Diff #73874) | Hm, perhaps replace "for example" with "either manually or", so it reads as ... variable in /etc/rc.conf, either manually or by running sysrc... What do you think? |