net-im/py-slackclient: Update to 2.7.1
AbandonedPublic
Actions

Authored by dereks_lifeofadishwasher.com on Jun 15 2020, 2:18 AM.

Details

Reviewers

Summary

net-im/py-slackclient: Update to 2.7.1

- Update to 2.7.1 [1][2]
- Remove pytest-runner dependency (only required for setup.py test command [3])
- Add ca_root_nss to TEST_DEPENDS (tests access https://slack.com/)
- Update MAINTAINER

[1] https://github.com/slackapi/python-slackclient/releases
[2] https://github.com/slackapi/python-slackclient/releases?after=v2.3.1
[3] https://github.com/slackapi/python-slackclient/pull/725

Approved by: koobs (maintainer)
Differential_Revision: D25275
MFH: 2020Q2 (blanket: consistent  metadata (maintainer))

Test Plan

portlint: ok. looks fine.
testport: ok. 12amd64.
unittest: ok. 233 passed, 1 skipped in 17.63 seconds.

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 31710
Build 29280: arc lint + arc unit

Event Timeline

dereks_lifeofadishwasher.com requested review of this revision.Jun 15 2020, 2:18 AM

dereks_lifeofadishwasher.com created this revision.

Harbormaster completed remote builds in B31709: Diff 73124.Jun 15 2020, 2:18 AM

koobs edited the summary of this revision. (Show Details)Jun 15 2020, 2:36 AM

koobs edited the test plan for this revision. (Show Details)

Should separate out the maintainer such from the rest such that it can be MFH'd to quarterly so that MAINTAINER is consistent between branches

net-im/py-slackclient/Makefile
37–39	I'd use a straight patch here

Update MAINTAINER at a later time.
Turn pytest-running int a straight patch

Harbormaster completed remote builds in B31710: Diff 73125.Jun 15 2020, 3:11 AM

dereks_lifeofadishwasher.com marked an inline comment as done.Jun 17 2020, 6:00 AM

dereks_lifeofadishwasher.com edited the summary of this revision. (Show Details)Jun 18 2020, 11:35 PM

koobs added inline comments.Jun 21 2020, 3:56 AM

net-im/py-slackclient/Makefile
10	Don't want to maintain?

dereks_lifeofadishwasher.com added inline comments.Jun 21 2020, 4:00 AM

net-im/py-slackclient/Makefile
10	In D25275#557380, @koobs wrote: Should separate out the maintainer such from the rest such that it can be MFH'd to quarterly so that MAINTAINER is consistent between branches I do however I think I misunderstood this comment then. What did you mean by this?