Page MenuHomeFreeBSD

net-im/py-slackclient: Update to 2.7.1
Needs ReviewPublic

Authored by dereks_lifeofadishwasher.com on Jun 15 2020, 2:18 AM.

Details

Reviewers
koobs
Summary
net-im/py-slackclient: Update to 2.7.1

- Update to 2.7.1 [1][2]
- Remove pytest-runner dependency (only required for setup.py test command [3])
- Add ca_root_nss to TEST_DEPENDS (tests access https://slack.com/)
- Update MAINTAINER

[1] https://github.com/slackapi/python-slackclient/releases
[2] https://github.com/slackapi/python-slackclient/releases?after=v2.3.1
[3] https://github.com/slackapi/python-slackclient/pull/725

Approved by: koobs (maintainer)
Differential_Revision: D25275
MFH: 2020Q2 (blanket: consistent  metadata (maintainer))
Test Plan
  • portlint: ok. looks fine.
  • testport: ok. 12amd64.
  • unittest: ok. 233 passed, 1 skipped in 17.63 seconds.

Diff Detail

Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 31710
Build 29280: arc lint + arc unit

Event Timeline

koobs edited the test plan for this revision. (Show Details)

Should separate out the maintainer such from the rest such that it can be MFH'd to quarterly so that MAINTAINER is consistent between branches

net-im/py-slackclient/Makefile
36–38

I'd use a straight patch here

Update MAINTAINER at a later time.
Turn pytest-running int a straight patch

net-im/py-slackclient/Makefile
10

Don't want to maintain?

net-im/py-slackclient/Makefile
10

Should separate out the maintainer such from the rest such that it can be MFH'd to quarterly so that MAINTAINER is consistent between branches

I do however I think I misunderstood this comment then. What did you mean by this?

net-im/py-slackclient/Makefile
10

Ah, all changes are fine here, i'll just split out the changes into separate commits if i need to :)