Page MenuHomeFreeBSD
Differential D24995

x11/libxfce4menu: Update fix for leaked keygrabs when layout changes
ClosedPublic
Actions

Authored by madpilot on May 25 2020, 8:30 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 24, 2:51 AM
Unknown Object (File)
Fri, Jan 24, 1:21 AM
Unknown Object (File)
Sat, Jan 18, 2:09 AM
Unknown Object (File)
Dec 27 2024, 7:47 PM
Unknown Object (File)
Dec 18 2024, 6:44 PM
Unknown Object (File)
Dec 9 2024, 3:52 PM
Unknown Object (File)
Nov 12 2024, 2:48 PM
Unknown Object (File)
Nov 8 2024, 5:50 AM
View All Files
Subscribers
mat

Details

Reviewers
cem
madpilot
Group Reviewers
xfce
Commits
rP542340: MFH: r542258
rP542258: Update patch to Fix leaked keygrabs when layout changes to code
Summary

Update to the fix proposed by cem in [1].

This patch uses the glib GArray API to have growing list of old keycodes instead of using a fixed size array.

The patch is submitted upstream at [2].

[1] https://reviews.freebsd.org/D24338

[2] https://gitlab.xfce.org/xfce/libxfce4ui/-/merge_requests/1

Test Plan

I'm runing this on my machine without problems.

I'd like someone else to confirm it works properly.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 31292
Build 28933: arc lint + arc unit

Event Timeline

madpilot created this revision.May 25 2020, 8:30 AM
Herald added a subscriber: mat. · View Herald TranscriptMay 25 2020, 8:30 AM
madpilot requested review of this revision.May 25 2020, 8:30 AM
Harbormaster completed remote builds in B31286: Diff 72217.May 25 2020, 8:30 AM
madpilot added inline comments.May 25 2020, 8:32 AM
x11/libxfce4menu/files/patch-libxfce4kbd-private_xfce-shortcuts-grabber.c
17–18

I suspect this check is not really necessary anymore, but not completely sure.

I also was not able to find documentation about the behavior of g_array_index() when one asks to access an element beyond the end of the array.

madpilot updated this revision to Diff 72234.May 25 2020, 1:58 PM

Align patch with the one sent upstream.

Harbormaster completed remote builds in B31292: Diff 72234.May 25 2020, 1:58 PM
madpilot accepted this revision as: xfce.Jul 15 2020, 1:24 PM
madpilot accepted this revision.
This revision is now accepted and ready to land.Jul 15 2020, 1:24 PM
Closed by commit rP542258: Update patch to Fix leaked keygrabs when layout changes to code (authored by madpilot). · Explain WhyJul 15 2020, 1:27 PM
This revision was automatically updated to reflect the committed changes.
madpilot added a commit: rP542258: Update patch to Fix leaked keygrabs when layout changes to code.
madpilot added a commit: rP542340: MFH: r542258.Jul 16 2020, 8:49 AM

Revision Contents
Changeset List

PathSize
x11/
libxfce4menu/
2 lines
files/
118 lines

Diff 72234

View Options

x11/libxfce4menu/Makefile

Loading...
View Options

x11/libxfce4menu/files/patch-libxfce4kbd-private_xfce-shortcuts-grabber.c

Loading...