Details

Reviewers

koobs
skreuzer

Commits

rP529940: sysutils/py-crontab: Rename to python-crontab, Update to 2.4.0

Summary

Proposed commit log message:

sysutils/py-crontab: Rename to python-crontab, Update to 2.4.0

- Rename the port to match the canonical/registered (PyPI/CHEESESHOP) name
- Switch from CHEESESHOP to GitLab for complete tests data
- Update the project website URL in pkg-descr
- Add LICENSE_FILE
- Add sysutils/py-cron-descriptor to RUN_DEPENDS
- Add test target

Reviewed_by: koobs
Approved by: koobs (ports, mentor), portmgr (maintainer timeout: > 2 weeks)
Differential_Revision: D23968

Test Plan

portlint: OK (looks fine.)
testport: OK (poudriere: 1300077, [amd64, i386, armv7, aarch64], 'BUILD_ALL_PYTHON_FLAVORS=1', [py27, py35, py36, py37, py38] tested)
unittest: OK (

Python2.7 on armv7: Ran 167 tests in 5.670s OK
Python3.5 on armv7: Ran 167 tests in 7.932s OK
Python3.6 on armv7: Ran 167 tests in 7.875s OK
Python3.7 on armv7: Ran 167 tests in 8.801s OK
Python3.8 on armv7: Ran 167 tests in 7.285s OK
)

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 29909
Build 27728: arc lint + arc unit

Event Timeline

loader created this revision.Mar 5 2020, 6:45 AM

Herald added a subscriber: mat. · View Herald TranscriptMar 5 2020, 6:45 AM

Harbormaster completed remote builds in B29796: Diff 69202.Mar 5 2020, 6:45 AM

loader edited the summary of this revision. (Show Details)Mar 5 2020, 6:47 AM

loader edited the test plan for this revision. (Show Details)

loader edited the test plan for this revision. (Show Details)Mar 5 2020, 6:53 AM

loader edited the summary of this revision. (Show Details)Mar 6 2020, 4:40 AM

You can try to use USE_LOCAL=<locale> or TEST_ENV+=LANG=whatever to set a more appropriate locale (the one that tests 'rely' on)

If that doesn't work you can commit and report it upstream to get them to fix the implicit locale requirement for a long term fix, excluding the failing test from the test run in the meantime (if you can)

This revision is now accepted and ready to land.Mar 9 2020, 2:29 AM

Set locale to UTF-8

This revision now requires review to proceed.Mar 12 2020, 11:24 AM

Harbormaster completed remote builds in B29897: Diff 69419.Mar 12 2020, 11:24 AM

loader edited the test plan for this revision. (Show Details)Mar 12 2020, 11:26 AM

In D23968#527744, @koobs wrote:

You can try to use USE_LOCAL=<locale> or TEST_ENV+=LANG=whatever to set a more appropriate locale (the one that tests 'rely' on)

Thanks @koobs. I have updated it with TEST_ENV.

Nice!

This revision is now accepted and ready to land.Mar 12 2020, 12:07 PM

Remove unused DISTVERSIONPREFIX

This revision now requires review to proceed.Mar 13 2020, 3:45 AM

Harbormaster completed remote builds in B29909: Diff 69446.Mar 13 2020, 3:45 AM

koobs requested changes to this revision.Mar 13 2020, 3:48 AM

koobs added inline comments.

sysutils/py-crontab/Makefile
4	I missed this in the initial review, apologies. The canonical/registered (PyPI/CHEESESHOP) name for this package is `python-crontab` [1] and the port should be moved/renamed accordingly [1] https://pypi.org/project/python-crontab/