devel/py-yaml: Rename to py-pyyaml To match upstream naming [1] move py-yaml to py-pyyaml [1] https://wiki.freebsd.org/Python/PortsPolicy#Naming Approved by: koobs (python, maintainer) MFH: No Differential_Revision: D23803
Details
Details
Rebuild all updated ports.
~1500 ports need built to test this but it did at least get past poudriere dep. checks.
Diff Detail
Diff Detail
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 29769 Build 27606: arc lint + arc unit
Event Timeline
Comment Actions
From a technical standpoint this looks good.
From a practical standpoint I wonder if this change is worth the churn. This would mean pkg install py36-yaml wouldn't work anymore? The port name has been around for 17 years, it's not hard to imagine there's tooling and muscle memory built up around it.
Comment Actions
Conversely, there will have and continue to be users that pkg install 'pyyaml' using the name referenced by upstream and in all current and future documentation, and the names used by all packages that depend on it, that dont/cant find it.
pyyaml and python-dateutil are one of the very few outstanding incorrectly named python packages in the tree preventing us from getting to a better place in python port packaging regarding calling things exactly what they're called
| devel/Makefile | ||
|---|---|---|
| 5146–5147 | Re-order this line (alphabetically) | |
Comment Actions
@dereks_lifeofadishwasher.com Can you check if this still applies and update it if necessary? @danilo is current maintainer and can handle resolution
Comment Actions
Looks like some ports were removed between then (2/2020) and today (7/2021). Forget the exact method to update the tree at the time however this was used.
- Move py-yaml.
- Update py-pyyaml's PORTNAME
- find files with ...yaml at word boundary.
- Undo some changes that aren't needed (UPDATING, MOVED, vuxml).
- Add entry to MOVED.
- By hand update devel/Makefile to be alpha. order.
git mv devel/py-yaml devel/py-pyyaml
sed -i"" -e '/^PORTNAME=/s/yaml/pyyaml/' devel/py-pyyaml/Makefile
git grep -lze '${PYTHON_PKGNAMEPREFIX}yaml[[:>:]]' -e 'py-yaml[[:>:]]' | while read -r -d '' file ; do
sed -i "" 's/${PYTHON_PKGNAMEPREFIX}yaml[[:>:]]/${PYTHON_PKGNAMEPREFIX}pyyaml/g;s/py-yaml[[:>:]]/py-pyyaml/g' "$file"
done
git checkout security/vuxml MOVED UPDATING
echo "devel/py-yaml|devel/py-pyyaml|$(date '+%F')|Match upstream (PyPI) name (Python Policy)" >> MOVEDComment Actions
Thanks you for rebasing/updating this differential Derek. Minor update request (MOVED reason)
| MOVED | ||
|---|---|---|
| 14391 | Minor change request: Match upstream (PyPI) name (Python Policy) | |
Comment Actions
rebasing this on current main updating devel/py-pyyaml PORTNAME
rebasing this on current main didn't realize a major part was missing... devel/py-pyyaml PORTNAME
was never changed. This was clearly pointed out by poudriere-devel warnings:
[00:00:16] [Dry Run] Warning: cad/python-gdsii dependency on devel/py-pyyaml@py39 has wrong PKGNAME of 'py39-pyyaml' but should be 'py39-yaml'; Is the dependency missing`
Update comment 702768 to include that change:
git mv devel/py-yaml devel/py-pyyaml
sed -i"" -e '/^PORTNAME=/s/yaml/pyyaml/' devel/py-pyyaml/Makefile
git grep -lze '${PYTHON_PKGNAMEPREFIX}yaml[[:>:]]' -e 'py-yaml[[:>:]]' | while read -r -d '' file ; do
sed -i "" 's/${PYTHON_PKGNAMEPREFIX}yaml[[:>:]]/${PYTHON_PKGNAMEPREFIX}pyyaml/g;s/py-yaml[[:>:]]/py-pyyaml/g' "$file"
done
git checkout security/vuxml MOVED UPDATING
echo "devel/py-yaml|devel/py-pyyaml|$(date '+%F')|Match upstream (PyPI) name (Python Policy)" >> MOVED