Page MenuHomeFreeBSD
Differential D23858

[handbook] bsdinstall update Setting the Time Zone section
ClosedPublic
Actions

Authored by carlavilla on Feb 27 2020, 6:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 20, 4:39 AM
Unknown Object (File)
Sat, Apr 19, 9:09 AM
Unknown Object (File)
Fri, Apr 11, 4:03 PM
Unknown Object (File)
Tue, Apr 8, 9:46 AM
Unknown Object (File)
Sat, Mar 29, 5:45 AM
Unknown Object (File)
Mar 14 2025, 5:46 PM
Unknown Object (File)
Mar 13 2025, 9:35 AM
Unknown Object (File)
Feb 8 2025, 5:12 AM
View All 57 Files
Subscribers
None

Details

Reviewers
bcr
Commits
rD53939: Update Setting the Time Zone section in the handbook
Summary

[handbook] bsdinstall update Setting the Time Zone section

Test Plan

Compile the handbook

Diff Detail

Repository
rD FreeBSD doc repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

carlavilla created this revision.Feb 27 2020, 6:47 PM
bcr added a comment.Feb 27 2020, 7:37 PM

Looks good so far, just two more commas to add.

en_US.ISO8859-1/books/handbook/bsdinstall/chapter.xml
2247

s/Otherwise/Otherwise,/

2264

same here as above

carlavilla updated this revision to Diff 68910.Feb 27 2020, 8:13 PM

Fixed!

bcr accepted this revision.Feb 27 2020, 8:22 PM

Approved then! Thank you.

This revision is now accepted and ready to land.Feb 27 2020, 8:22 PM
Closed by commit rD53939: Update Setting the Time Zone section in the handbook (authored by carlavilla). · Explain WhyFeb 27 2020, 8:26 PM
This revision was automatically updated to reflect the committed changes.
carlavilla added a commit: rD53939: Update Setting the Time Zone section in the handbook.

Revision Contents
Changeset List

Diff 68910

View Options

en_US.ISO8859-1/books/handbook/Makefile

  • This file was added.
/*-
* Copyright (c) 2023 The FreeBSD Foundation
*
* This software was developed by Robert Clausecker <fuz@FreeBSD.org>
* under sponsorship from the FreeBSD Foundation.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ''AS IS'' AND
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
* ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE
*/
#define FLS flsll
#define TYPE long long
#define TYPE_MIN LLONG_MIN
ngieUnsubmitted
Not Done
Inline Actions

Why don't you just modify the CFLAGS to define these things at build time instead of creating a ton of basically boilerplate C files?

ngie: Why don't you just modify the CFLAGS to define these things at build time instead of creating a…
fuzAuthorUnsubmitted
Done
Inline Actions

I was copying the design pattern used for string functions. If this is not how I am supposed to write test cases, could you point me at some example I can copy?

fuz: I was copying the design pattern used for string functions. If this is not how I am supposed…
#include "fls_test.c"
View Options

en_US.ISO8859-1/books/handbook/bsdinstall/chapter.xml

  • This file was added.
/*-
* Copyright (c) 2023 The FreeBSD Foundation
*
* This software was developed by Robert Clausecker <fuz@FreeBSD.org>
* under sponsorship from the FreeBSD Foundation.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ''AS IS'' AND
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
* ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE
*/
#define FLS flsll
#define TYPE long long
#define TYPE_MIN LLONG_MIN
ngieUnsubmitted
Not Done
Inline Actions

Why don't you just modify the CFLAGS to define these things at build time instead of creating a ton of basically boilerplate C files?

ngie: Why don't you just modify the CFLAGS to define these things at build time instead of creating a…
fuzAuthorUnsubmitted
Done
Inline Actions

I was copying the design pattern used for string functions. If this is not how I am supposed to write test cases, could you point me at some example I can copy?

fuz: I was copying the design pattern used for string functions. If this is not how I am supposed…
#include "fls_test.c"
View Options

share/images/books/handbook/bsdinstall/bsdinstall-timezone-confirm.png

  • This file was added.
/*-
* Copyright (c) 2023 The FreeBSD Foundation
*
* This software was developed by Robert Clausecker <fuz@FreeBSD.org>
* under sponsorship from the FreeBSD Foundation.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ''AS IS'' AND
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
* ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE
*/
#define FLS flsll
#define TYPE long long
#define TYPE_MIN LLONG_MIN
ngieUnsubmitted
Not Done
Inline Actions

Why don't you just modify the CFLAGS to define these things at build time instead of creating a ton of basically boilerplate C files?

ngie: Why don't you just modify the CFLAGS to define these things at build time instead of creating a…
fuzAuthorUnsubmitted
Done
Inline Actions

I was copying the design pattern used for string functions. If this is not how I am supposed to write test cases, could you point me at some example I can copy?

fuz: I was copying the design pattern used for string functions. If this is not how I am supposed…
#include "fls_test.c"
View Options

share/images/books/handbook/bsdinstall/bsdinstall-timezone-country.png

  • This file was added.
/*-
* Copyright (c) 2023 The FreeBSD Foundation
*
* This software was developed by Robert Clausecker <fuz@FreeBSD.org>
* under sponsorship from the FreeBSD Foundation.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ''AS IS'' AND
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
* ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE
*/
#define FLS flsll
#define TYPE long long
#define TYPE_MIN LLONG_MIN
ngieUnsubmitted
Not Done
Inline Actions

Why don't you just modify the CFLAGS to define these things at build time instead of creating a ton of basically boilerplate C files?

ngie: Why don't you just modify the CFLAGS to define these things at build time instead of creating a…
fuzAuthorUnsubmitted
Done
Inline Actions

I was copying the design pattern used for string functions. If this is not how I am supposed to write test cases, could you point me at some example I can copy?

fuz: I was copying the design pattern used for string functions. If this is not how I am supposed…
#include "fls_test.c"
View Options

share/images/books/handbook/bsdinstall/bsdinstall-timezone-date.png

Loading...
View Options

share/images/books/handbook/bsdinstall/bsdinstall-timezone-region.png

Loading...
View Options

share/images/books/handbook/bsdinstall/bsdinstall-timezone-time.png

Loading...
View Options

share/images/books/handbook/bsdinstall/bsdinstall-timezone-zone.png

Loading...