Don't convert all lower-layer errors to EIO.
ClosedPublic
Actions

Authored by imp on Feb 19 2020, 3:36 PM.

Tags

None

Referenced Files

	F105944582: D23755.diff
	Sun, Dec 22, 10:31 PM

	Unknown Object (File)
	Wed, Dec 11, 8:25 AM

	Unknown Object (File)
	Sun, Dec 8, 10:21 PM

	Unknown Object (File)
	Oct 18 2024, 4:05 AM

	Unknown Object (File)
	Oct 3 2024, 1:33 PM

	Unknown Object (File)
	Oct 3 2024, 10:16 AM

	Unknown Object (File)
	Oct 1 2024, 4:52 PM

	Unknown Object (File)
	Sep 30 2024, 7:00 PM

View All 50 Files

Subscribers

None

Details

Reviewers

kib

Commits

rS358143: Don't convert all lower-layer errors to EIO.

Summary

Don't convert all lower layer errors to EIO. Instead, pass the actual error up
the stack. This will allow the upper layers that look for ENXIO to react
properly to that signal from the lower layers and, for UFS, unmount the
filesystem.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Feb 19 2020, 3:36 PM

Harbormaster completed remote builds in B29491: Diff 68530.Feb 19 2020, 3:37 PM

imp added a reviewer: kib.Feb 19 2020, 3:38 PM

kib added inline comments.Feb 19 2020, 3:42 PM

sys/vm/vnode_pager.c
632 ↗	(On Diff #68530)	Perhaps assert that error != 0, there and in other chunk.

assert error != 0 when B_ERROR flagged

Harbormaster completed remote builds in B29498: Diff 68549.Feb 19 2020, 6:03 PM

kib accepted this revision.Feb 20 2020, 12:34 AM

This revision is now accepted and ready to land.Feb 20 2020, 12:34 AM

Closed by commit rS358143: Don't convert all lower-layer errors to EIO. (authored by imp). · Explain WhyFeb 20 2020, 1:33 AM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rS358143: Don't convert all lower-layer errors to EIO..

Revision Contents
Changeset List

Path

Size

head/

sys/

vm/

vnode_pager.c

11 lines

Diff 68570

View Options

Don't convert all lower-layer errors to EIO.ClosedPublicActions