Don't convert all lower-layer errors to EIO.
ClosedPublic
Actions

Authored by imp on Feb 19 2020, 3:36 PM.

Details

Reviewers

Commits

rS358143: Don't convert all lower-layer errors to EIO.

Summary

Don't convert all lower layer errors to EIO. Instead, pass the actual error up
the stack. This will allow the upper layers that look for ENXIO to react
properly to that signal from the lower layers and, for UFS, unmount the
filesystem.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29491
Build 27361: arc lint + arc unit

Event Timeline

imp created this revision.Feb 19 2020, 3:36 PM

Harbormaster completed remote builds in B29491: Diff 68530.Feb 19 2020, 3:37 PM

imp added a reviewer: kib.Feb 19 2020, 3:38 PM

kib added inline comments.Feb 19 2020, 3:42 PM

sys/vm/vnode_pager.c
632	Perhaps assert that error != 0, there and in other chunk.

assert error != 0 when B_ERROR flagged

Harbormaster completed remote builds in B29498: Diff 68549.Feb 19 2020, 6:03 PM

kib accepted this revision.Feb 20 2020, 12:34 AM

This revision is now accepted and ready to land.Feb 20 2020, 12:34 AM

Closed by commit rS358143: Don't convert all lower-layer errors to EIO. (authored by imp). · Explain WhyFeb 20 2020, 1:33 AM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rS358143: Don't convert all lower-layer errors to EIO..

Revision Contents
Changeset List

Path

Size

sys/

vm/

vnode_pager.c

4 lines

Diff 68530

View Options

sys/vm/vnode_pager.c

Property	Old Value	New Value
svn:eol-style	native \ No newline at end of property	null
svn:keywords	FreeBSD=%H \ No newline at end of property	null
svn:mime-type	text/plain \ No newline at end of property	null

This file was completely deleted. Show File Contents

Don't convert all lower-layer errors to EIO.ClosedPublicActions