go.mk: Add GO_TESTTARGET and provide default do-test (take #2)
ClosedPublic
Actions

Authored by dmgk on Nov 16 2019, 7:02 PM.

Details

Reviewers

Group Reviewers

O5: Ports Framework	(Owns No Changed Paths)
portmgr

Commits

rP526567: Mk/Uses/go.mk: Add GO_TESTTARGET and provide default do-test
rP517831: Mk/Uses/go.mk: Add GO_TEST_TARGET and provide default do-test

Summary

Add GO_TESTTARGET defaulting to `./...` (the current package and all
subpackages) and create do-test target unless already provided by port's
Makefile.

In many cases this would allow us to remove explicit do-test and rely on
defaults provided by ports framework for testing.

While here also

- remove GO_WRKDIR_SRC - it is not used anywhere anymore
- sync GO_PKGNAME and GO_TARGET descriptions with Porter's Handbook

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 29454
Build 27330: arc lint + arc unit

Event Timeline

dmgk created this revision.Nov 16 2019, 7:02 PM

Owners added a reviewer: O5: Ports Framework.Nov 16 2019, 7:02 PM

Herald added a reviewer: portmgr. · View Herald TranscriptNov 16 2019, 7:02 PM

Herald added a subscriber: mat. · View Herald Transcript

Harbormaster completed remote builds in B27583: Diff 64457.Nov 16 2019, 7:02 PM

LGTM. Thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Nov 17 2019, 4:19 PM

Closed by commit rP517831: Mk/Uses/go.mk: Add GO_TEST_TARGET and provide default do-test (authored by dmgk). · Explain Why

This revision was automatically updated to reflect the committed changes.

dmgk added a commit: rP517831: Mk/Uses/go.mk: Add GO_TEST_TARGET and provide default do-test.

dmgk reopened this revision.Feb 17 2020, 7:26 PM

dmgk retitled this revision from Mk/Uses/go.mk: Add GO_TEST_TARGET and provide default do-test to Mk/Uses/go.mk: Add GO_TESTTARGET and provide default do-test (take #2).

dmgk edited the summary of this revision. (Show Details)

Rename to GO_TESTTARGET to avoid sanity check false positives.

Harbormaster completed remote builds in B29454: Diff 68468.Feb 17 2020, 7:32 PM

tobik accepted this revision.Feb 18 2020, 8:34 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 20 2020, 12:15 PM

Closed by commit rP526567: Mk/Uses/go.mk: Add GO_TESTTARGET and provide default do-test (authored by dmgk). · Explain Why

This revision was automatically updated to reflect the committed changes.

dmgk added a commit: rP526567: Mk/Uses/go.mk: Add GO_TESTTARGET and provide default do-test.