Paths

Table of Contentst

Differential D23725

editors/emacs: Add optional workaround for Fcitx input method
ClosedPublic
Actions

Authored by jrm on Feb 17 2020, 3:00 AM.

Details

Reviewers

ashish

Commits

rP526478: editors/emacs: Add optional workaround for Fcitx input method

Summary

Don't forget to add 'Approved by:' and 'Differential Revision:' **

PR: 242012
Submitted by:
Reported by:

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 29443
Build 27320: arc lint + arc unit

Event Timeline

jrm created this revision.Feb 17 2020, 3:00 AM

Harbormaster completed remote builds in B29437: Diff 68436.Feb 17 2020, 3:00 AM

I have not built it, but the patch seems to apply fine (including with canna flavour). Should we add an implicit dependency on X11 for FCITXPATCH option, as patch is useless in nox flavour, AFAICS ?

ashish added inline comments.Feb 17 2020, 10:17 AM

editors/emacs/Makefile
114–115	Maybe we can add `FCITXPATCH` here ?

Exclude FCITXPATCH when flavor is nox

Harbormaster completed remote builds in B29443: Diff 68451.Feb 17 2020, 11:12 AM

jrm marked an inline comment as done.Feb 17 2020, 11:13 AM

jrm added inline comments.

editors/emacs/Makefile
114–115	I think you're right. Done.

Looks good to me.

Thank you!

This revision is now accepted and ready to land.Feb 18 2020, 7:45 AM

Closed by commit rP526478: editors/emacs: Add optional workaround for Fcitx input method (authored by jrm). · Explain WhyFeb 18 2020, 10:57 PM

This revision was automatically updated to reflect the committed changes.

jrm marked an inline comment as done.

jrm added a commit: rP526478: editors/emacs: Add optional workaround for Fcitx input method.

Revision Contents
Changeset List

Path

Size

editors/

emacs/

Makefile

17 lines

files/

extra-patch-src_xfns.c

12 lines

Diff 68451

View Options

editors/emacs/Makefile