Page MenuHomeFreeBSD
Differential D23725

editors/emacs: Add optional workaround for Fcitx input method
ClosedPublic
Actions

Authored by jrm on Feb 17 2020, 3:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 29, 12:13 PM
Unknown Object (File)
Sun, Mar 29, 2:57 AM
Unknown Object (File)
Sat, Mar 28, 6:03 PM
Unknown Object (File)
Fri, Mar 13, 10:42 AM
Unknown Object (File)
Thu, Mar 12, 11:42 PM
Unknown Object (File)
Sun, Mar 8, 6:13 PM
Unknown Object (File)
Mar 1 2026, 6:20 AM
Unknown Object (File)
Feb 23 2026, 10:40 PM
View All Files
Subscribers
None

Details

Reviewers
ashish
Commits
rP526478: editors/emacs: Add optional workaround for Fcitx input method
Summary
  • Don't forget to add 'Approved by:' and 'Differential Revision:' **

PR: 242012
Submitted by:
Reported by:

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 29437
Build 27314: arc lint + arc unit

Event Timeline

jrm created this revision.Feb 17 2020, 3:00 AM
Harbormaster completed remote builds in B29437: Diff 68436.Feb 17 2020, 3:00 AM
ashish added a comment.Feb 17 2020, 10:16 AM

I have not built it, but the patch seems to apply fine (including with canna flavour). Should we add an implicit dependency on X11 for FCITXPATCH option, as patch is useless in nox flavour, AFAICS ?

ashish added inline comments.Feb 17 2020, 10:17 AM
editors/emacs/Makefile
115

Maybe we can add FCITXPATCH here ?

jrm updated this revision to Diff 68451.Feb 17 2020, 11:12 AM

Exclude FCITXPATCH when flavor is nox

Harbormaster completed remote builds in B29443: Diff 68451.Feb 17 2020, 11:12 AM
jrm marked an inline comment as done.Feb 17 2020, 11:13 AM
jrm added inline comments.
editors/emacs/Makefile
115

I think you're right. Done.

ashish accepted this revision.Feb 18 2020, 7:45 AM

Looks good to me.

Thank you!

This revision is now accepted and ready to land.Feb 18 2020, 7:45 AM
Closed by commit rP526478: editors/emacs: Add optional workaround for Fcitx input method (authored by jrm). · Explain WhyFeb 18 2020, 10:57 PM
This revision was automatically updated to reflect the committed changes.
jrm marked an inline comment as done.
jrm added a commit: rP526478: editors/emacs: Add optional workaround for Fcitx input method.

Revision Contents
Changeset List

PathSize
editors/
emacs/
9 lines
files/
12 lines

Diff 68436

View Options

editors/emacs/Makefile

Loading...
View Options

editors/emacs/files/extra-patch-src_xfns.c

Loading...