Page MenuHomeFreeBSD
Differential D3018

Fix recursive variable substitution in jail.conf
ClosedPublic
Actions

Authored by hrs on Jul 7 2015, 6:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 12, 1:45 PM
Unknown Object (File)
Sat, Oct 11, 11:19 PM
Unknown Object (File)
Sat, Oct 11, 11:18 PM
Unknown Object (File)
Sat, Oct 11, 9:51 PM
Unknown Object (File)
Sat, Oct 11, 9:34 PM
Unknown Object (File)
Sat, Oct 11, 8:36 PM
Unknown Object (File)
Fri, Oct 10, 5:31 PM
Unknown Object (File)
Sun, Oct 5, 5:49 AM
View All Files
Subscribers
imp

Details

Reviewers
jamie
Commits
rS285261: Fix offset calculation in variable substitution
Summary

As reported in PR 189139, variable substitution is broken when
A="A_${B}_C_${D}", B="BBBBB", D="DDDD_${E}_FFFFF", and E="EEEEE" are
defined.

This patch fixes the offset length calculation.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

hrs updated this revision to Diff 6759.Jul 7 2015, 6:46 PM
hrs retitled this revision from to Fix recursive variable substitution in jail.conf.
hrs updated this object.
hrs edited the test plan for this revision. (Show Details)
hrs added a reviewer: jamie.
Herald added a subscriber: imp. · View Herald TranscriptJul 7 2015, 6:46 PM
jamie edited edge metadata.Jul 7 2015, 8:47 PM

Looks good to me :-)

Closed by commit rS285261: Fix offset calculation in variable substitution (authored by hrs). · Explain WhyJul 8 2015, 12:51 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
usr.sbin/
jail/
16 lines

Diff 6759

View Options

usr.sbin/jail/config.c

Loading...