Page MenuHomeFreeBSD
Differential D2798

lang/rust-nightly: New port for the development version of Rust
ClosedPublic
Actions

Authored by dumbbell on Jun 12 2015, 6:05 PM.
Tags
None
Referenced Files
F102959512: D2798.diff
Tue, Nov 19, 5:24 AM
Unknown Object (File)
Fri, Nov 15, 2:44 PM
Unknown Object (File)
Fri, Nov 15, 1:58 PM
Unknown Object (File)
Tue, Nov 5, 5:35 AM
Unknown Object (File)
Mon, Nov 4, 8:54 AM
Unknown Object (File)
Mon, Oct 28, 3:41 AM
Unknown Object (File)
Mon, Oct 28, 3:41 AM
Unknown Object (File)
Mon, Oct 28, 3:38 AM
View All Files
Subscribers
None

Details

Reviewers
jonathan
kwm
Commits
rP392106: lang/rust-nightly: New port for the nightly version of Rust
Summary

The patch lacks a modification to lang/rust to declare the conflict, but there is already a pending review for lang/rust (D2466).

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

dumbbell updated this revision to Diff 6147.Jun 12 2015, 6:05 PM
dumbbell retitled this revision from to lang/rust-nightly: New port for the development version of Rust.
dumbbell updated this object.
dumbbell edited the test plan for this revision. (Show Details)
dumbbell added reviewers: kwm, jonathan.
dumbbell mentioned this in D2799: devel/cargo: New port for Rust's package manager.Jun 12 2015, 6:07 PM
dumbbell added a child revision: D2799: devel/cargo: New port for Rust's package manager.Jun 17 2015, 8:21 AM
dumbbell updated this revision to Diff 6434.Jun 24 2015, 5:16 PM

Repost diff

kwm added inline comments.Jun 27 2015, 7:49 PM
lang/rust-nightly/Makefile
70

.include <bsd.port.options.mk> while this port doesn't have options you don't have to hassle with pre.mk/post.mk ..

123

.include <bsd.port.mk>

dumbbell updated this revision to Diff 6570.Jun 30 2015, 11:06 AM

Include bsd.port.options.mk and bsd.port.mk

dumbbell marked 2 inline comments as done.Jun 30 2015, 11:07 AM

Followed @kwm advice.

dumbbell updated this revision to Diff 6686.Jul 4 2015, 9:36 AM

Checkout latest commit

kwm edited edge metadata.Jul 5 2015, 8:55 PM

After that suggestion looks good enough to me to commit. Unless you want to wait for jonathan?

lang/rust-nightly/pkg-plist
5

how about replacing the 7e44814b with %%VERSION%% (bad name suggestion) and adding a PLIST_SUB+= VERSION=7e44814b in the Makefile? that way the plist will not change that much.

dumbbell updated this revision to Diff 6733.Jul 6 2015, 4:08 PM
dumbbell edited edge metadata.

Specify the correct Rust channel

While here, compute %%RUST_VSN_HASH%% in the Makefile and replace it in
the PLIST.

dumbbell added a comment.Jul 6 2015, 4:10 PM

Once the RUST_VSN_HASH is polished, I will prepare the same change to lang/rust.

dumbbell updated this revision to Diff 6746.Jul 7 2015, 6:45 AM

Take maintainership

jonathan accepted this revision.Jul 10 2015, 6:40 PM
jonathan edited edge metadata.

Sorry that I've been a bit unresponsive. I see no problems here, but then again I'm neither a Ports nor a Rust expert!

This revision is now accepted and ready to land.Jul 10 2015, 6:40 PM
Closed by commit rP392106: lang/rust-nightly: New port for the nightly version of Rust (authored by dumbbell). · Explain WhyJul 14 2015, 10:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
lang/
1 line
131 lines
12 lines
10 lines
14 lines
86 lines

Diff 6733

View Options

lang/Makefile

Loading...
View Options

lang/rust-nightly/

Loading...
View Options

lang/rust-nightly/Makefile

Loading...
View Options

lang/rust-nightly/distinfo

Loading...
View Options

lang/rust-nightly/files/

Loading...
View Options

lang/rust-nightly/files/patch-configure

Loading...
View Options

lang/rust-nightly/pkg-descr

Loading...
View Options

lang/rust-nightly/pkg-plist

Loading...