Differential D2944

Create option target helpers.
ClosedPublic
Actions

Authored by mat on Jun 29 2015, 3:54 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Apr 29, 10:41 AM

	Unknown Object (File)
	Mon, Apr 29, 10:41 AM

	Unknown Object (File)
	Mon, Apr 29, 10:41 AM

	Unknown Object (File)
	Mon, Apr 29, 10:41 AM

	Unknown Object (File)
	Wed, Apr 24, 2:33 PM

	Unknown Object (File)
	Tue, Apr 23, 10:59 PM

	Unknown Object (File)
	Tue, Apr 23, 2:47 PM

	Unknown Object (File)
	Tue, Apr 23, 8:22 AM

Subscribers

None

Details

Reviewers

None

Group Reviewers

Commits

rP391051: Introduce target option helpers.

Summary

It will permit replacing:

  .include <bsd.port.options.mk>
  
  post-patch:
	  ${REINPLACE_CMD} -e 's|/usr/local|${LOCALBASE}|g' \
		  ${WRKSRC}/Configure ${WRKSRC}/hints/freebsd.sh
  .if ${PORT_OPTIONS:MPTHREAD}
	  ${REINPLACE_CMD} -e 's|%%PTHREAD_LIBS%%|-lpthread|g;' \
		  ${WRKSRC}/hints/freebsd.sh
  .else
	  ${REINPLACE_CMD} -e 's|%%PTHREAD_LIBS%%||g;' \
		  ${WRKSRC}/hints/freebsd.sh
  .endif

with:

  post-patch:
	  ${REINPLACE_CMD} -e 's|/usr/local|${LOCALBASE}|g' \
		  ${WRKSRC}/Configure ${WRKSRC}/hints/freebsd.sh
  post-patch-PTHREAD-on:
	  ${REINPLACE_CMD} -e 's|%%PTHREAD_LIBS%%|-lpthread|g;' \
		  ${WRKSRC}/hints/freebsd.sh
  post-patch-PTHREAD-off:
	  ${REINPLACE_CMD} -e 's|%%PTHREAD_LIBS%%||g;' \
		  ${WRKSRC}/hints/freebsd.sh

so that there's even less need to .include bsd.port.options.mk.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

mat updated this revision to Diff 6551.Jun 29 2015, 3:54 PM

mat retitled this revision from to Create option target helpers..

mat updated this object.

mat edited the test plan for this revision. (Show Details)

mat added a reviewer: portmgr.

Herald edited edge metadata. · View Herald TranscriptJun 29 2015, 3:54 PM

mat updated this object.Jun 30 2015, 1:43 PM

mat edited edge metadata.

Looks like pre-stage-*-o{n,ff} were forgotten there. Also there is no pre-stage target.

mat added a child revision: D2957: Document the target helpers from D2944..Jun 30 2015, 2:29 PM

Closed by commit rP391051: Introduce target option helpers. (authored by mat). · Explain WhyJul 1 2015, 12:11 PM

This revision was automatically updated to reflect the committed changes.

mat updated this object.Jul 6 2015, 9:44 AM

mat mentioned this in D2957: Document the target helpers from D2944..

Revision Contents
Changeset List

Path

Size

Mk/

22 lines

28 lines

Diff 6580

Mk/bsd.options.mk

Loading...

Mk/bsd.port.mk

Loading...