Page MenuHomeFreeBSD
Differential D22693

net/pjsip: Unbreak IPV6 option
ClosedPublic
Actions

Authored by tobik on Dec 5 2019, 3:50 PM.
Tags
None
Referenced Files
F167956096: D22693.diff
Tue, Aug 25, 3:07 PM
F167928173: D22693.id.diff
Tue, Aug 25, 11:38 AM
Unknown Object (File)
Sun, Aug 23, 2:45 PM
Unknown Object (File)
Sun, Aug 23, 11:26 AM
Unknown Object (File)
Sat, Aug 22, 4:05 PM
Unknown Object (File)
Thu, Aug 20, 2:27 PM
Unknown Object (File)
Mon, Aug 17, 3:25 PM
Unknown Object (File)
Sat, Aug 15, 1:06 PM
View All Files
Subscribers
mat

Details

Reviewers
madpilot
Commits
rP520006: net/pjsip: Unbreak IPV6 option
Summary

Flagged by one of my ports tools due to setting IPV6_CFLAGS twice.
PJ_HAS_IPV6 is always set to 1 regardless of option state. Set it
to 0 when the option is off.

Test Plan

Confirmed building in Poudriere on 12.0 amd64 with IPV6 on and off,
but I cannot verify if the option actually does something beyond
that.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 27983
Build 26146: arc lint + arc unit

Event Timeline

tobik created this revision.Dec 5 2019, 3:50 PM
Herald added a subscriber: mat. · View Herald TranscriptDec 5 2019, 3:50 PM
Harbormaster completed remote builds in B27983: Diff 65270.Dec 5 2019, 3:50 PM
This revision was not accepted when it landed; it landed in state Needs Review.Dec 13 2019, 7:23 AM
Closed by commit rP520006: net/pjsip: Unbreak IPV6 option (authored by tobik). · Explain Why
This revision was automatically updated to reflect the committed changes.
tobik added a commit: rP520006: net/pjsip: Unbreak IPV6 option.

Revision Contents
Changeset List

PathSize
net/
pjsip/
5 lines

Diff 65270

View Options

net/pjsip/Makefile

Loading...