sysutils/vagrant: update to 1.7.2
ClosedPublic
Actions

Authored by mmoll on Jun 26 2015, 10:21 PM.

Details

Reviewers

swills
mat

Commits

rP391004: sysutils/vagrant: update to 1.7.2

Summary

I have two positive reports about a slightly earlier patchset from two people. Unfortunantely the maintainer did not react to any of my mails, so I would commit this and the dependent differentials after obtaining clearance here.
Proposed commit message:

sysutils/vagrant: update to 1.7.2

- switch to USE_GITHUB
- cleanup RUN_DEPENDS

Approved by:	swills (mentor), mat (mentor), Joe Benden (maintainer, timeout)

Test Plan

poudriere: http://space.kvedulv.de/FreeBSD/vagrant/
portlint:

mmoll@marduk:/svn/ports/sysutils/vagrant$ portlint -ACNc
WARN: /svn/ports/sysutils/vagrant/pkg-plist: [2]: enumerating info files in the plist is deprecated in favor of adding info files into the Makefile using the INFO macro.
WARN: Makefile: [0]: possible direct use of command "install" found. use ${INSTALL_foobaa} instead.
WARN: /svn/ports/sysutils/vagrant/files/patch-vagrant-is-vagrant-installer.patch: patch was not generated using ``make makepatch''.  It is recommended to use ``make makepatch'' to ensure proper patch format.
0 fatal errors and 3 warnings found.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

mmoll updated this revision to Diff 6484.Jun 26 2015, 10:21 PM

mmoll retitled this revision from to sysutils/vagrant: update to 1.7.2.

mmoll updated this object.

mmoll edited the test plan for this revision. (Show Details)

mmoll added a parent revision: D2917: sysutils/rubygem-winrm: update to 1.3.3.Jun 26 2015, 10:25 PM

mmoll added reviewers: swills, mat.Jun 26 2015, 10:28 PM

swills added inline comments.Jun 26 2015, 10:42 PM

sysutils/vagrant/Makefile
17	Shouldn't this be 1.7?
36	Should set DISTVERSIONPREFIX instead.

use DISTVERSIONPREFIX

mat added inline comments.Jun 26 2015, 11:02 PM

sysutils/vagrant/Makefile
35	That should go, it's the default.

mmoll marked 2 inline comments as done.Jun 26 2015, 11:08 PM

mmoll added inline comments.

sysutils/vagrant/Makefile
17	The gemspec says ">=1.5.3, <1.8.0" and does indeed not work with newer bundler versions (which was the reason why sysutils/bundler17 was created). However, I try to reflect the versions in the gemspec in ports Makefiles.