graphics/py-Pyganim: create port
ClosedPublic
Actions

Authored by xmj on Jun 24 2015, 5:19 AM.

Details

Reviewers

Group Reviewers

Summary

graphics/py-pyganim: create port
Pyganim (pronounced like "pig" and "animation") is a Python module for Pygame
that makes it easy to add sprite animations to your Pygame game programs.
Pyganim works with Python 2 and Python 3.

The mascot of Pyganim is a red vitruvian pig.

Pyganim was written by Al Sweigart and released under a "Simplified BSD"
license. Contact Al with any questions/bug reports: al@inventwithpython.com

WWW: http://inventwithpython.com/pyganim

Test Plan

portlint: looks fine
poudriere: ok

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

xmj updated this revision to Diff 6417.Jun 24 2015, 5:19 AM

xmj retitled this revision from to graphics/py-Pyganim: create port.

xmj updated this object.

xmj edited the test plan for this revision. (Show Details)

xmj added a reviewer: Python.

xmj updated this object.Jun 24 2015, 5:21 AM

koobs requested changes to this revision.Jun 24 2015, 6:27 AM

koobs added a reviewer: koobs.

koobs added a subscriber: koobs.

koobs added inline comments.

graphics/Makefile
805	Lowercase P
graphics/py-Pyganim/Makefile
4 ↗	(On Diff #6417)	Lowercase P
13 ↗	(On Diff #6417)	No LICENSE_FILE?
15–16 ↗	(On Diff #6417)	Sure its a BUILD_DEPENDS, and not just RUN? I can't see pygame declared at upstream setup.py at all, let alone setup_requires
20 ↗	(On Diff #6417)	Upstream setup.py has test_suite declared [1]. Add regression-test target to run it [1] https://github.com/asweigart/pyganim/blob/master/setup.py#L18

This revision now requires changes to proceed.Jun 24 2015, 6:27 AM

xmj marked 3 inline comments as done.Jun 24 2015, 6:37 AM

xmj added inline comments.

graphics/py-Pyganim/Makefile
4 ↗	(On Diff #6417)	This is for consistency with Upstream name. "PORTNAME MUST be equal to <PyPI-name> " :)
13 ↗	(On Diff #6417)	No. I've asked the maintainer which BSD license it is, and he said 2-clause. Excerpt: Subject: Re: Pyganim BSD license From: Al Sweigart <al@inventwithpython.com> To: Johannes Jost Meixner <xmj@freebsd.org> Hi Johannes. It's under the Simplified 2-paragraph BSD license. I'll make this more apparent in the docs. Thanks! Feel free to email me if you have any questions about it.
15–16 ↗	(On Diff #6417)	Yes, because it doesn't build otherwise.