[update] lang/gcc10-devel add new plugin support option
ClosedPublic
Actions

Authored by gerald on Nov 9 2019, 4:55 PM.

Details

Reviewers

devnexen_gmail.com
gerald

Commits

rP523406: Backport (part of) r521207 | gerald | 2019-12-28 from lang/gcc9-devel:
rP517725: Backport 517206 | gerald | 2019-11-10 from lang/gcc10-devel, which already
rP517355: Backport 517206 | gerald | 2019-11-10 from lang/gcc10-devel:
rP517206: Add a new option PLUGINS that enables GCC's plugin framework. This is off

Summary

Some few ports might have some use, for instance AFL/AFL++ for the gcc wrapper fast mode.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

devnexen_gmail.com created this revision.Nov 9 2019, 4:55 PM

Herald added a subscriber: mat. · View Herald TranscriptNov 9 2019, 4:55 PM

I started with one gcc flavour only to see if it can appeal.

In D22292#487463, @devnexen_gmail.com wrote:

I started with one gcc flavour only to see if it can appeal.

This makes sense, and I recommend to stay with gcc10-devel (as it is going to lead
to gcc10 next year) and perhaps gcc9 as the default version of GCC.

Definitely a good approach to start from the most current.

I believe this can (and should) be simplified to

PLUGINS_CONFIGURE_ARGS=plugin

instead of

.if ${PORT_OPTIONS:MPLUGINS}
CONFIGURE_ARGS+=--enable-plugin
.endif

Can you please see whether that still works for you?

This revision now requires changes to proceed.Nov 9 2019, 8:57 PM

gerald commandeered this revision.Nov 9 2019, 9:06 PM

gerald edited reviewers, added: devnexen_gmail.com; removed: gerald.

This revision now requires review to proceed.Nov 9 2019, 9:06 PM

Per my previous comment. Note I actually meant PLUGINS_CONFIGURE_ENABLE, and use that in this patch.

Fixed patch (option helpers need to come earlier in the Makefile) that I am testing now.

gerald added a reviewer: gerald.Nov 9 2019, 9:48 PM

linimon retitled this revision from [update] gcc10-devel add new plugin support option to [update] lang/gcc10-devel add new plugin support option.Nov 9 2019, 11:07 PM