Page MenuHomeFreeBSD

[update] lang/gcc10-devel add new plugin support option
ClosedPublic

Authored by gerald on Nov 9 2019, 4:55 PM.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

I started with one gcc flavour only to see if it can appeal.

I started with one gcc flavour only to see if it can appeal.

This makes sense, and I recommend to stay with gcc10-devel (as it is going to lead
to gcc10 next year) and perhaps gcc9 as the default version of GCC.

Definitely a good approach to start from the most current.

gerald requested changes to this revision.Nov 9 2019, 8:57 PM

I believe this can (and should) be simplified to

PLUGINS_CONFIGURE_ARGS=plugin

instead of

.if ${PORT_OPTIONS:MPLUGINS}
CONFIGURE_ARGS+=--enable-plugin
.endif

Can you please see whether that still works for you?

This revision now requires changes to proceed.Nov 9 2019, 8:57 PM
gerald edited reviewers, added: devnexen_gmail.com; removed: gerald.
This revision now requires review to proceed.Nov 9 2019, 9:06 PM

Per my previous comment. Note I actually meant PLUGINS_CONFIGURE_ENABLE, and use that in this patch.

Fixed patch (option helpers need to come earlier in the Makefile) that I am testing now.

linimon retitled this revision from [update] gcc10-devel add new plugin support option to [update] lang/gcc10-devel add new plugin support option.Nov 9 2019, 11:07 PM

Fixed patch (option helpers need to come earlier in the Makefile) that I am testing now.

Works for me . Thanks

This revision was not accepted when it landed; it landed in state Needs Review.Nov 10 2019, 1:11 PM
This revision was automatically updated to reflect the committed changes.

Thanks for proposing this. As I mentioned in the commit I plan on making the same change to
lang/gcc9-devel and later lang/gcc9 as well.