Differential D22026

mail/milter-callback: don't add -fnested-functions on head on powerpc*
ClosedPublic
Actions

Authored by pkubaj on Oct 14 2019, 5:45 PM.

Details

Reviewers

linimon

Commits

rP514519: Conditionalize the inclusion of the -fnested-functions flag on GCC.

Summary

With powerpc* soon switching to clang on head, GCC from ports will be used and it doesn't accept -fnested-functions.

Test Plan

linimon
mat
tcberner

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 27026
Build 25315: arc lint + arc unit

Event Timeline

pkubaj created this revision.Oct 14 2019, 5:45 PM

Herald added subscribers: Contributor Reviewers (ports), mat. · View Herald TranscriptOct 14 2019, 5:45 PM

Harbormaster completed remote builds in B27026: Diff 63262.Oct 14 2019, 5:45 PM

linimon added a reviewer: linimon.Oct 15 2019, 12:23 AM

As per my prior feedback, this does indeed fix the problem on elfv2 but breaks it on elfv1/13:

/wrkdirs/usr/ports/mail/milter-callback/work/milter-callback-1.6.0/cache.c: In function 'extendCache':
/wrkdirs/usr/ports/mail/milter-callback/work/milter-callback-1.6.0/cache.c:338: error: nested functions are disabled, use -fnested-functions to re-enable

This revision was not accepted when it landed; it landed in state Needs Review.Oct 15 2019, 12:43 PM

Closed by commit rP514519: Conditionalize the inclusion of the -fnested-functions flag on GCC. (authored by linimon). · Explain Why

This revision was automatically updated to reflect the committed changes.

linimon added a commit: rP514519: Conditionalize the inclusion of the -fnested-functions flag on GCC..