Page MenuHomeFreeBSD
Differential D21996

Mk/bsd.port.mk: don't switch to ld.bfd on powerpc64 with clang
ClosedPublic
Actions

Authored by pkubaj on Oct 12 2019, 4:29 PM.
Tags
None
Referenced Files
F140102180: D21996.id63197.diff
Sat, Dec 20, 6:20 AM
Unknown Object (File)
Thu, Dec 11, 9:48 PM
Unknown Object (File)
Sat, Nov 29, 5:29 PM
Unknown Object (File)
Thu, Nov 27, 7:28 PM
Unknown Object (File)
Wed, Nov 26, 11:03 AM
Unknown Object (File)
Nov 20 2025, 3:15 AM
Unknown Object (File)
Nov 20 2025, 3:15 AM
Unknown Object (File)
Nov 20 2025, 3:15 AM
View All Files
Subscribers
None

Details

Reviewers
linimon
mat
tcberner
Group Reviewers
portmgr
O5: Ports Framework(Owns No Changed Paths)
Commits
rP514354: Mk/bsd.port.mk: use GNU LD from ports on powerpc64 elfv2 when GNU LD is required
Summary

With powerpc64 soon switching to clang, it doesn't make sense to use base ld.bfd when LLD_UNSAFE is defined.

Accepted by portmgr in PR 239743

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 27002
Build 25296: arc lint + arc unit

Event Timeline

pkubaj created this revision.Oct 12 2019, 4:29 PM
Owners added a reviewer: O5: Ports Framework.Oct 12 2019, 4:29 PM
Herald added a reviewer: portmgr. · View Herald TranscriptOct 12 2019, 4:29 PM
Harbormaster completed remote builds in B27002: Diff 63185.Oct 12 2019, 4:29 PM
pkubaj removed reviewers: O5: Ports Framework, portmgr.Oct 12 2019, 4:30 PM
Herald added a reviewer: portmgr. · View Herald TranscriptOct 12 2019, 4:30 PM
pkubaj removed a reviewer: portmgr.Oct 12 2019, 4:30 PM
Herald added a reviewer: portmgr. · View Herald TranscriptOct 12 2019, 4:30 PM
pkubaj added a comment.Oct 12 2019, 4:30 PM

Looks like phabricator requires portmgr in reviewers, but it was actually already accepted by portmgr.

tcberner accepted this revision.Oct 12 2019, 7:51 PM

Lgtm. Decide for yourself whether you want to wait for an explicit approval by portmgr.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 12 2019, 8:49 PM
Closed by commit rP514354: Mk/bsd.port.mk: use GNU LD from ports on powerpc64 elfv2 when GNU LD is required (authored by pkubaj). · Explain Why
This revision was automatically updated to reflect the committed changes.
pkubaj added a commit: rP514354: Mk/bsd.port.mk: use GNU LD from ports on powerpc64 elfv2 when GNU LD is required.
Owners added a reviewer: O5: Ports Framework.Oct 12 2019, 8:49 PM

Revision Contents
Changeset List

PathSize
Mk/
5 lines

Diff 63185

View Options

Mk/bsd.port.mk

Loading...