cherry-pick memory corruption bug fix from github
ClosedPublic
Actions

Authored by lprylli_netflix.com on Sep 26 2019, 5:12 PM.

Tags

None

Referenced Files

	F131581565: D21804.diff
	Thu, Oct 9, 11:39 AM

	Unknown Object (File)
	Sat, Sep 27, 2:52 PM

	Unknown Object (File)
	Sat, Sep 27, 5:16 AM

	Unknown Object (File)
	Sat, Sep 20, 11:38 AM

	Unknown Object (File)
	Sat, Sep 20, 11:25 AM

	Unknown Object (File)
	Sat, Sep 20, 11:19 AM

	Unknown Object (File)
	Sat, Sep 20, 11:16 AM

	Unknown Object (File)
	Fri, Sep 19, 9:54 AM

View All Files

Subscribers

None

Details

Reviewers

imp

Commits

rP512986: The code creates a lambda function that takes by reference the core_id local

Summary

lambda function passed to thread was using possibly obsolete reference from a stack variable.

https://github.com/opcm/pcm/commit/0ea6edeed6dab1cc0bd0c22f772640ddcde232af

Test Plan

crash behavior no long appear after fix

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

lprylli_netflix.com created this revision.Sep 26 2019, 5:12 PM

Harbormaster completed remote builds in B26719: Diff 62604.Sep 26 2019, 5:12 PM

This looks good to me. I'll update the port with it shortly.

This revision is now accepted and ready to land.Sep 26 2019, 5:33 PM

Closed by commit rP512986: The code creates a lambda function that takes by reference the core_id local (authored by imp). · Explain WhySep 26 2019, 8:53 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rP512986: The code creates a lambda function that takes by reference the core_id local.

Revision Contents
Changeset List

Path

Size

head/

sysutils/

intel-pcm/

Makefile

1 line

files/

patch-cpucounters.cpp

11 lines

Diff 62620

View Options

head/sysutils/intel-pcm/Makefile