cherry-pick memory corruption bug fix from github
ClosedPublic
Actions

Authored by lprylli_netflix.com on Sep 26 2019, 5:12 PM.

Tags

None

Referenced Files

	F164596789: D21804.diff
	Sun, Aug 2, 6:33 AM

	Unknown Object (File)
	Sat, Jul 25, 4:04 PM

	Unknown Object (File)
	Wed, Jul 22, 6:23 AM

	Unknown Object (File)
	Tue, Jul 21, 12:47 PM

	Unknown Object (File)
	Mon, Jul 20, 4:07 AM

	Unknown Object (File)
	Jun 24 2026, 7:16 PM

	Unknown Object (File)
	Jun 22 2026, 11:34 AM

	Unknown Object (File)
	Jun 17 2026, 2:59 AM

View All Files

Subscribers

None

Details

Reviewers

imp

Commits

rP512986: The code creates a lambda function that takes by reference the core_id local

Summary

lambda function passed to thread was using possibly obsolete reference from a stack variable.

https://github.com/opcm/pcm/commit/0ea6edeed6dab1cc0bd0c22f772640ddcde232af

Test Plan

crash behavior no long appear after fix

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 26719
Build 25079: arc lint + arc unit

Event Timeline

lprylli_netflix.com created this revision.Sep 26 2019, 5:12 PM

Harbormaster completed remote builds in B26719: Diff 62604.Sep 26 2019, 5:12 PM

This looks good to me. I'll update the port with it shortly.

This revision is now accepted and ready to land.Sep 26 2019, 5:33 PM

Closed by commit rP512986: The code creates a lambda function that takes by reference the core_id local (authored by imp). · Explain WhySep 26 2019, 8:53 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rP512986: The code creates a lambda function that takes by reference the core_id local.

Revision Contents
Changeset List

Path

Size

sysutils/

intel-pcm/

Makefile

1 line

files/

patch-cpucounters.cpp

11 lines

Diff 62604

View Options

sysutils/intel-pcm/Makefile