Differential D21544

Reduce code duplication by calling fetch target
ClosedPublic
Actions

Authored by bapt on Sep 6 2019, 8:20 AM.

Details

Reviewers

None

Group Reviewers

portmgr

Commits

rP513191: Reduce code duplication by calling fetch target

Summary

when converting the do-fetch target to proper scripting
we lost the ability to overwrite do-fetch when running make makesum.
as reported here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=215530

Let's call again do-fetch directly instead of duplicating its content

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 26302
Build 24781: arc lint + arc unit

Event Timeline

bapt created this revision.Sep 6 2019, 8:20 AM

Herald added 1 blocking reviewer(s): portmgr. · View Herald TranscriptSep 6 2019, 8:20 AM

Herald added a subscriber: mat. · View Herald Transcript

Harbormaster completed remote builds in B26302: Diff 61718.Sep 6 2019, 8:20 AM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 29 2019, 4:15 AM

Closed by commit rP513191: Reduce code duplication by calling fetch target (authored by bapt). · Explain Why

This revision was automatically updated to reflect the committed changes.

bapt added a commit: rP513191: Reduce code duplication by calling fetch target.

This comment has been deleted.

head/Mk/bsd.port.mk
3876 ↗	(On Diff #62697)	Shouldn't it call do-fetch? It is what the commit message says.

Revision Contents
Changeset List

Path

Size

Mk/

bsd.port.mk

16 lines

Diff 61718

View Options

Reduce code duplication by calling fetch targetClosedPublicActions