ping6: Fix insufficient privileges bug introduced by r350857
ClosedPublic
Actions

Authored by jansucan on Aug 18 2019, 7:21 PM.

Tags

None

Referenced Files

	F163039861: D21319.diff
	Sun, Jul 19, 12:37 PM

	Unknown Object (File)
	Wed, Jul 8, 1:03 AM

	Unknown Object (File)
	Tue, Jul 7, 11:02 PM

	Unknown Object (File)
	Mon, Jun 29, 5:52 PM

	Unknown Object (File)
	Mon, Jun 29, 5:52 PM

	Unknown Object (File)
	Thu, Jun 25, 6:48 PM

	Unknown Object (File)
	Mon, Jun 22, 6:53 PM

	Unknown Object (File)
	Mon, Jun 22, 6:18 PM

View All Files

Subscribers

imp

Details

Reviewers

asomers

Commits

rS351216: ping6: revert r350857

Summary

Fix insufficient privileges bug introduced by r350857

Calls to setsockopt(IPV6_RECV*OPTS) need root privilege.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25948
Build 24507: arc lint + arc unit

Event Timeline

jansucan created this revision.Aug 18 2019, 7:21 PM

Harbormaster completed remote builds in B25948: Diff 60974.Aug 18 2019, 7:21 PM

Is this a full revocation of r350857?

Yes.

asomers accepted this revision.Aug 19 2019, 2:20 PM

This revision is now accepted and ready to land.Aug 19 2019, 2:20 PM

Closed by commit rS351216: ping6: revert r350857 (authored by asomers). · Explain WhyAug 19 2019, 2:20 PM

This revision was automatically updated to reflect the committed changes.

asomers added a commit: rS351216: ping6: revert r350857.

Herald added a subscriber: imp. · View Herald TranscriptAug 19 2019, 2:20 PM

Revision Contents
Changeset List

Path

Size

sbin/

ping6/

ping6.c

12 lines

Diff 60974

View Options

ping6: Fix insufficient privileges bug introduced by r350857ClosedPublicActions