Page MenuHomeFreeBSD
Differential D21260

ping6: Raise WARNS level to 6
ClosedPublic
Actions

Authored by jansucan on Aug 14 2019, 7:09 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 1 2025, 10:21 AM
Unknown Object (File)
Feb 1 2025, 8:35 AM
Unknown Object (File)
Jan 25 2025, 8:14 PM
Unknown Object (File)
Jan 24 2025, 7:18 PM
Unknown Object (File)
Jan 24 2025, 6:53 PM
Unknown Object (File)
Jan 20 2025, 4:51 PM
Unknown Object (File)
Jan 20 2025, 7:49 AM
Unknown Object (File)
Jan 11 2025, 12:48 PM
View All Files
Subscribers
imp

Details

Reviewers
asomers
Commits
rS352252: MFC r351172:
rS351172: ping6: Raise WARNS level to 6
Summary

Raise WARNS level to 6

Submitted by: Ján Sučan <sucanjan@gmail.com>
Sponsored by: Google, inc. (Google Summer of Code 2019)

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25934
Build 24496: arc lint + arc unit

Event Timeline

jansucan created this revision.Aug 14 2019, 7:09 AM
Harbormaster completed remote builds in B25867: Diff 60775.Aug 14 2019, 7:09 AM
jansucan added a comment.Aug 14 2019, 7:11 AM

This depends on D21217.

asomers mentioned this in D21217: ping6: Fix alignment errors.Aug 14 2019, 10:54 PM
asomers requested changes to this revision.Aug 17 2019, 2:52 PM
asomers added inline comments.
sbin/ping6/Makefile
10

6 is the default, so you can simply remove this line.

This revision now requires changes to proceed.Aug 17 2019, 2:52 PM
jansucan updated this revision to Diff 60944.Aug 17 2019, 3:08 PM

Remove WARNS. 6 is the default level.

Harbormaster completed remote builds in B25934: Diff 60944.Aug 17 2019, 3:08 PM
jansucan added inline comments.Aug 17 2019, 3:13 PM
sbin/ping6/Makefile
10

Fixed.

asomers accepted this revision.Aug 17 2019, 5:20 PM
This revision is now accepted and ready to land.Aug 17 2019, 5:20 PM
Closed by commit rS351172: ping6: Raise WARNS level to 6 (authored by asomers). · Explain WhyAug 17 2019, 5:22 PM
This revision was automatically updated to reflect the committed changes.
asomers added a commit: rS351172: ping6: Raise WARNS level to 6.
Herald added a subscriber: imp. · View Herald TranscriptAug 17 2019, 5:22 PM
asomers added a commit: rS352252: MFC r351172:.Sep 12 2019, 4:23 PM

Revision Contents
Changeset List

PathSize
sbin/
ping6/
1 line

Diff 60944

View Options

sbin/ping6/Makefile

# Created by: Wen Heping <wenheping@gmail.com> # Created by: Wen Heping <wenheping@gmail.com>
# $FreeBSD$ # $FreeBSD$
PORTNAME= pyliblo PORTNAME= pyliblo
PORTVERSION= 0.10.0 DISTVERSION= 0.10.0
PORTREVISION= 1
CATEGORIES= audio python CATEGORIES= audio python
MASTER_SITES= http://das.nasophon.de/download/ MASTER_SITES= http://das.nasophon.de/download/
PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX} PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX}
MAINTAINER= ports@FreeBSD.org MAINTAINER= ports@FreeBSD.org
COMMENT= Python wrapper for the Liblo OSC Library COMMENT= Python wrapper for the Liblo OSC Library
LICENSE= LGPL21 LICENSE= LGPL21
LICENSE_FILE= ${WRKSRC}/COPYING LICENSE_FILE= ${WRKSRC}/COPYING
BUILD_DEPENDS= pyrex>=0.9.4:devel/pyrex \ BUILD_DEPENDS= cython${PYTHON_VER:M3.*:S/^3/-3/}:lang/cython${PYTHON_MAJOR_VER:M3}
${LOCALBASE}/bin/cython:lang/cython
LIB_DEPENDS= liblo.so:audio/liblo LIB_DEPENDS= liblo.so:audio/liblo
USES= localbase:ldflags python
USES= python USES= python
USE_PYTHON= distutils USE_PYTHON= distutils # autoplist fails to add the manpage files
matUnsubmitted
Not Done
Inline Actions

I don't understand the comment here.

USE_PYTHON=autoplist looks at what files distutils has installed and uses that to generate the plist.

In this port, the man pages are installed manually in post-install, so there is no way that distutils knows about them, so it seems normal that they are not present in the plist generated by autoplist.

mat: I don't understand the comment here. `USE_PYTHON=autoplist` looks at what files `distutils`…
MAKE_ENV+= PREFIX=${PREFIX} LOCALBASE=${LOCALBASE} MAKE_ENV+= PREFIX=${PREFIX} LOCALBASE=${LOCALBASE}
LDFLAGS+= -L${LOCALBASE}/lib
post-patch: post-patch:
${REINPLACE_CMD} -e 's#%%LOCALBASE%%#${LOCALBASE}#g' ${WRKSRC}/setup.py ${REINPLACE_CMD} -e 's#%%LOCALBASE%%#${LOCALBASE}#g' ${WRKSRC}/setup.py
post-install: post-install:
${STRIP_CMD} ${STAGEDIR}${PYTHONPREFIX_SITELIBDIR}/liblo.so ${STRIP_CMD} ${STAGEDIR}${PYTHONPREFIX_SITELIBDIR}/liblo.so
${INSTALL_MAN} ${WRKSRC}/scripts/dump_osc.1 ${STAGEDIR}${MAN1PREFIX}/man/man1 ${INSTALL_MAN} ${WRKSRC}/scripts/dump_osc.1 ${STAGEDIR}${MAN1PREFIX}/man/man1
${INSTALL_MAN} ${WRKSRC}/scripts/send_osc.1 ${STAGEDIR}${MAN1PREFIX}/man/man1 ${INSTALL_MAN} ${WRKSRC}/scripts/send_osc.1 ${STAGEDIR}${MAN1PREFIX}/man/man1
.include <bsd.port.mk> .include <bsd.port.mk>