Paths

Table of Contentst

Differential D21262

If pkg-message is not a UCL file, assume the message is "install" only.
ClosedPublic
Actions

Authored by mat on Aug 14 2019, 12:48 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Apr 4, 9:07 PM

	Unknown Object (File)
	Thu, Apr 2, 5:37 PM

	Unknown Object (File)
	Wed, Apr 1, 12:08 PM

	Unknown Object (File)
	Thu, Mar 19, 2:04 AM

	Unknown Object (File)
	Wed, Mar 18, 11:10 AM

	Unknown Object (File)
	Sun, Mar 15, 2:51 AM

	Unknown Object (File)
	Sat, Mar 14, 10:49 AM

	Unknown Object (File)
	Mar 1 2026, 8:28 PM

Subscribers

Details

Reviewers

None

Group Reviewers

Commits

rP509282: Add a QA check warning porters about non UCL pkg-message files.
rP509281: If pkg-message is not a UCL file, assume the message is "install" only.

Summary

Add a QA check warning porters about non UCL pkg-message files.

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 25870
Build 24441: arc lint + arc unit

Event Timeline

mat created this revision.Aug 14 2019, 12:48 PM

Harbormaster completed remote builds in B25870: Diff 60780.Aug 14 2019, 12:48 PM

adamw added a subscriber: adamw.Aug 14 2019, 5:48 PM

adamw added inline comments.

Mk/Scripts/qa.sh
1002	Maybe `${message} not in UCL format, will be shown on initial install only."` would be clearer? I don't know how long the string can be, but maybe add `"See https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/pkg-files.html#porting-message"` to help porters.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 19 2019, 12:18 PM

Closed by commit rP509281: If pkg-message is not a UCL file, assume the message is "install" only. (authored by mat). · Explain Why

This revision was automatically updated to reflect the committed changes.

mat added a commit: rP509281: If pkg-message is not a UCL file, assume the message is "install" only..

Herald added 1 blocking reviewer(s): portmgr. · View Herald TranscriptAug 19 2019, 12:18 PM

mat added a commit: rP509282: Add a QA check warning porters about non UCL pkg-message files..Aug 19 2019, 12:18 PM

Revision Contents
Changeset List

Path

Size

Mk/

Scripts/

create-manifest.sh

2 lines

15 lines

1 line

Diff 60780

Mk/Scripts/create-manifest.sh

Loading...

Mk/Scripts/qa.sh

Loading...

Mk/bsd.port.mk

Loading...