ping: Make in_cksum() operate on u_char buffer
ClosedPublic
Actions

Authored by jansucan on Aug 14 2019, 7:41 AM.

Tags

None

Referenced Files

	F174621434: D21261.diff
	Sun, Oct 4, 6:02 PM

	F174589120: D21261.id60789.diff
	Sun, Oct 4, 11:39 AM

	Unknown Object (File)
	Sun, Sep 27, 10:27 PM

	Unknown Object (File)
	Fri, Sep 18, 10:26 PM

	Unknown Object (File)
	Fri, Sep 18, 10:23 PM

	Unknown Object (File)
	Fri, Sep 18, 10:02 PM

	Unknown Object (File)
	Aug 28 2026, 6:41 PM

	Unknown Object (File)
	Aug 11 2026, 11:33 AM

View All Files

Subscribers

imp

Details

Reviewers

asomers

Commits

rS351033: ping: Make in_cksum() operate on u_char buffer

Summary

Make in_cksum() operate on u_char buffer

This fixes -Wcast-align errors for in_cksum() calls when compiled with
WARNS=6.

Submitted by: Ján Sučan <sucanjan@gmail.com>
Sponsored by: Google, inc. (Google Summer of Code 2019)

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25868
Build 24439: arc lint + arc unit

Event Timeline

jansucan created this revision.Aug 14 2019, 7:41 AM

Harbormaster completed remote builds in B25868: Diff 60776.Aug 14 2019, 7:41 AM

asomers accepted this revision.Aug 14 2019, 4:54 PM

This revision is now accepted and ready to land.Aug 14 2019, 4:54 PM

Closed by commit rS351033: ping: Make in_cksum() operate on u_char buffer (authored by asomers). · Explain WhyAug 14 2019, 4:55 PM

This revision was automatically updated to reflect the committed changes.

asomers added a commit: rS351033: ping: Make in_cksum() operate on u_char buffer.

Herald added a subscriber: imp. · View Herald TranscriptAug 14 2019, 4:55 PM

asomers mentioned this in rS352357: MFC r350994, r350998, r351030, r351033, r351171, r351223, r351226, r351424.Sep 15 2019, 4:53 PM

Revision Contents
Changeset List

Path

Size

sbin/

ping/

ping.c

20 lines

Diff 60776

View Options

ping: Make in_cksum() operate on u_char bufferClosedPublicActions