Page MenuHomeFreeBSD
Differential D21177

Update Chinese Pinyin related ports:
ClosedPublic
Actions

Authored by delphij on Aug 7 2019, 7:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 24, 7:28 PM
Unknown Object (File)
Sat, Apr 19, 3:55 AM
Unknown Object (File)
Thu, Apr 17, 12:03 AM
Unknown Object (File)
Mar 31 2025, 1:37 PM
Unknown Object (File)
Mar 25 2025, 2:35 AM
Unknown Object (File)
Mar 15 2025, 2:05 PM
Unknown Object (File)
Feb 24 2025, 1:22 AM
Unknown Object (File)
Feb 22 2025, 8:57 PM
View All 98 Files
Subscribers
lichray_gmail.com

Details

Reviewers
henry.hu.sh_gmail.com
lichray_gmail.com
Commits
rP509067: Update Chinese Pinyin related ports:
Summary

chinese/ibus-libpinyin: 1.10.0 -> 1.11.1, enable OpenCC
chinese/libpinyin: 2.2.0 -> 2.3.0
textproc/ibus: 1.5.18 -> 1.5.20, while there also fix pkg-message for Qt

Reviewed: TBD

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 25823
Build 24395: arc lint + arc unit

Event Timeline

delphij created this revision.Aug 7 2019, 7:18 AM
Harbormaster completed remote builds in B25719: Diff 60533.Aug 7 2019, 7:18 AM
delphij set the repository for this revision to rP FreeBSD ports repository.Aug 7 2019, 7:19 AM
delphij added a reviewer: henry.hu.sh_gmail.com.
lichray_gmail.com accepted this revision.Aug 7 2019, 2:05 PM
lichray_gmail.com added a subscriber: lichray_gmail.com.

LGTM for the libpinyin part unless it breaks fcitx-libpinyin in a way I didn't know.

This revision is now accepted and ready to land.Aug 7 2019, 2:05 PM
henry.hu.sh_gmail.com requested changes to this revision.Aug 12 2019, 2:32 AM

With a minor change, the updated ibus-libpinyin works.

chinese/ibus-libpinyin/Makefile
22

You need to specify that this port needs its glib settings schema to be installed:
GLIB_SCHEMAS= com.github.libpinyin.ibus-libpinyin.gschema.xml

Otherwise, the engine crashes when you switch to this engine. I thought that it worked before, so I'm not sure what's the problem.

With this line, the corresponding line in pkg-plist can be removed.

This revision now requires changes to proceed.Aug 12 2019, 2:32 AM
delphij updated this revision to Diff 60710.Aug 13 2019, 5:22 AM

Address reviewer comments.

Harbormaster completed remote builds in B25823: Diff 60710.Aug 13 2019, 5:22 AM
delphij marked an inline comment as done.Aug 13 2019, 5:22 AM
henry.hu.sh_gmail.com accepted this revision.Aug 15 2019, 12:03 AM
This revision is now accepted and ready to land.Aug 15 2019, 12:03 AM
Closed by commit rP509067: Update Chinese Pinyin related ports: (authored by delphij). · Explain WhyAug 16 2019, 8:32 AM
This revision was automatically updated to reflect the committed changes.
delphij added a commit: rP509067: Update Chinese Pinyin related ports:.

Revision Contents
Changeset List

PathSize
chinese/
ibus-libpinyin/
11 lines
6 lines
files/
11 lines
11 lines
1 line
libpinyin/
10 lines
6 lines
files/
6 lines
6 lines
textproc/
ibus/
18 lines
6 lines
files/
11 lines
6 lines
59 lines

Diff 60710

View Options

chinese/ibus-libpinyin/Makefile

Loading...
View Options

chinese/ibus-libpinyin/distinfo

Loading...
View Options

chinese/ibus-libpinyin/files/patch-data_Makefile.am

Loading...
View Options

chinese/ibus-libpinyin/files/patch-data_Makefile.in

Loading...
View Options

chinese/ibus-libpinyin/pkg-plist

Loading...
View Options

chinese/libpinyin/Makefile

Loading...
View Options

chinese/libpinyin/distinfo

Loading...
View Options

chinese/libpinyin/files/patch-data_Makefile.in

Loading...
View Options

chinese/libpinyin/files/patch-libpinyin.pc.in

Loading...
View Options

textproc/ibus/Makefile

Loading...
View Options

textproc/ibus/distinfo

Loading...
View Options

textproc/ibus/files/patch-configure

Loading...
View Options

textproc/ibus/files/patch-data_dconf_make-dconf-override-db.sh

Loading...
View Options

textproc/ibus/pkg-message

Loading...
View Options

textproc/ibus/pkg-plist

Loading...