Page MenuHomeFreeBSD
Differential D21142

cad/lepton-eda: respect CFLAGS
ClosedPublic
Actions

Authored by pkubaj on Aug 2 2019, 10:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 14, 7:39 AM
Unknown Object (File)
Tue, May 7, 9:47 AM
Unknown Object (File)
Fri, May 3, 8:13 PM
Unknown Object (File)
Thu, May 2, 10:52 AM
Unknown Object (File)
Thu, May 2, 10:47 AM
Unknown Object (File)
Thu, May 2, 9:47 AM
Unknown Object (File)
Thu, May 2, 9:19 AM
Unknown Object (File)
Sat, Apr 20, 3:44 PM
View All 41 Files
Subscribers
None

Details

Reviewers
linimon
mat
tcberner
Commits
rP508162: cad/lepton-eda: respect CFLAGS
Summary

Building with base GCC fails with:
cc1: error: -Wuninitialized is not supported without -O

But this port should use the default -O2. Fix this with attached patch.

PR: 239311

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

pkubaj created this revision.Aug 2 2019, 10:11 PM
Harbormaster completed remote builds in B25651: Diff 60402.Aug 2 2019, 10:11 PM
tcberner accepted this revision.Aug 4 2019, 5:53 PM
tcberner added inline comments.
cad/lepton-eda/files/patch-cli_Makefile.am
8 ↗(On Diff #60402)

^ CLAGS oO

This revision is now accepted and ready to land.Aug 4 2019, 5:53 PM
pkubaj marked an inline comment as done.Aug 5 2019, 11:13 AM
pkubaj added inline comments.
cad/lepton-eda/files/patch-cli_Makefile.am
8 ↗(On Diff #60402)

Both CAIRO_PDF_CLAGS and CAIRO_PDF_CFLAGS don't seem to be used anywhere in the source code, so I will just leave it as is.

Closed by commit rP508162: cad/lepton-eda: respect CFLAGS (authored by pkubaj). · Explain WhyAug 5 2019, 11:15 AM
This revision was automatically updated to reflect the committed changes.
pkubaj added a commit: rP508162: cad/lepton-eda: respect CFLAGS.

Revision Contents
Changeset List

PathSize
head/
cad/
lepton-eda/
2 lines
files/
11 lines
11 lines
11 lines

Diff 60467

View Options

head/cad/lepton-eda/Makefile

Loading...
View Options

head/cad/lepton-eda/files/patch-cli_Makefile.am

Loading...
View Options

head/cad/lepton-eda/files/patch-liblepton_src_Makefile.am

Loading...
View Options

head/cad/lepton-eda/files/patch-schematic_src_Makefile.am

Loading...