sysutils/minipro: fix build with GCC-based architectures
ClosedPublic
Actions

Authored by pkubaj on Jul 1 2019, 11:32 AM.

Details

Reviewers

Commits

Summary

This port needs new GCC to build on GCC architectures.

Actually respect CC by not replacing it with clang, instead remove it to use CC passed from ports.

Also respect CFLAGS.

PR: 238515

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

mat accepted this revision.Jul 1 2019, 7:19 PM

This revision is now accepted and ready to land.Jul 1 2019, 7:19 PM

mat added inline comments.Jul 1 2019, 7:23 PM

sysutils/minipro/Makefile
27–29 ↗	(On Diff #59251)	Note that all this should be in a patch file, not be done with sed. https://www.freebsd.org/doc/en/books/porters-handbook/slow-patch.html#slow-patch-automatic-replacements

Put the changes to a separate patch and remove post-patch target.

Also, don't remove CC=gcc, but set CC?=gcc instead.

This revision now requires review to proceed.Jul 1 2019, 7:58 PM

pkubaj marked an inline comment as done.Jul 1 2019, 7:59 PM

mat added inline comments.Jul 5 2019, 4:45 PM

sysutils/minipro/files/patch-Makefile
13 ↗	(On Diff #59282)	Should be `?=` this appends the existing CFLAGS, thus not respecting what the user want. Say they want -O3, now the Makefile here adds -O0 disabling -O3.