Differential D20647

Extend simple_mfd driver to expose a syscon interface
ClosedPublic
Actions

Authored by ganbold on Jun 15 2019, 9:21 AM.

Details

Reviewers

Summary

Extend simple_mfd driver to expose a syscon interface if
that node is also compatible with syscon. For instance,
Rockchip RK3399's GRF (General Register Files) is compatible
with simple-mfd as well as syscon and has devices like
usb2-phy, emmc-phy and pcie-phy etc. under it.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 25175

Event Timeline

ganbold created this revision.Jun 15 2019, 9:21 AM

Herald added a subscriber: imp. · View Herald TranscriptJun 15 2019, 9:21 AM

Harbormaster completed remote builds in B24864: Diff 58657.Jun 15 2019, 9:21 AM

manu added inline comments.Jul 1 2019, 10:22 PM

sys/dev/fdt/simple_mfd.c
39	you need sys/mutex.h too otherwise it doesn't compile
47	#include <dev/fdt/simple_mfd.h>
154	The rid variable isn't needed

Updated.
Used #include <dev/fdt/simple_mfd.h>
It compiles and working fine without sys/mutex.h (for instance sys/dev/extres/syscon/* files doesn't use it)
rid var is needed for bus_alloc_resource_any()

Harbormaster completed remote builds in B25175: Diff 59302.Jul 2 2019, 4:57 AM

Updated.
Added sys/mutex.h

Harbormaster completed remote builds in B25179: Diff 59309.Jul 2 2019, 8:36 AM

manu accepted this revision.Jul 2 2019, 8:42 AM

This revision is now accepted and ready to land.Jul 2 2019, 8:42 AM

ganbold closed this revision.Jul 2 2019, 8:49 AM