Page MenuHomeFreeBSD
Differential D20660

editors/nano: Make several port improvements
ClosedPublic
Actions

Authored by koobs on Jun 16 2019, 9:05 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 11 2024, 1:10 AM
Unknown Object (File)
Dec 13 2023, 2:43 AM
Unknown Object (File)
Nov 14 2023, 6:44 PM
Unknown Object (File)
Nov 14 2023, 9:13 AM
Unknown Object (File)
Nov 5 2023, 7:25 PM
Unknown Object (File)
Oct 13 2023, 5:48 PM
Unknown Object (File)
Oct 13 2023, 11:53 AM
Unknown Object (File)
Oct 13 2023, 8:17 AM
View All 13 Files
Subscribers
mat

Details

Reviewers
danilo
Summary
editors/nano: Make several port improvements

  * Switch to https:// MASTER_SITES
  * Use provided .xz for distribution file, saving: 50.5% / 1415kB
  * Add LICENSE_FILE
  * Remove CPPFLAGS/LDFLAGS variables, added 19 years ago when the port
    was first created. [1] They are incorrectly (globally) scoped, no
    longer necessary and incorrect for the ncurses:base case. Instead use
    Uses/ncurses.mk variables and provide these to configure to ensure
    includes/lib searches and linking are never mixed between base and
    ports.

[1] ports r29979

Reviewed_by: danilo (maintainer)
Approved by: danilo (maintainer)
MFH: 2019Q2 (blanket: bugfix)
Differential_Revision: D20660
Test Plan
  • portlint: OK (looks fine.)
  • testport: OK (poudriere: {11,12}amd64, NLS=ON/OFF, ncurses: base/ports (ldd))
  • maketest: N/A (NONE)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 24875
Build 23614: arc lint + arc unit

Event Timeline

koobs created this revision.Jun 16 2019, 9:05 AM
Herald added a subscriber: mat. · View Herald TranscriptJun 16 2019, 9:05 AM
Harbormaster completed remote builds in B24875: Diff 58686.Jun 16 2019, 9:05 AM
koobs updated this revision to Diff 58687.Jun 16 2019, 9:09 AM

Remove leftover BUILD_DEPENDS used to force ports ncurses during base ncurses linking QA

Harbormaster completed remote builds in B24876: Diff 58687.Jun 16 2019, 9:09 AM
koobs edited the summary of this revision. (Show Details)Jun 16 2019, 9:09 AM
danilo added a comment.Jun 16 2019, 11:05 AM

I'm AFK for some days, if you think it is OK, please, commit it. Thank you.

koobs added a comment.Jun 16 2019, 11:39 AM

It's been well QA'd, and I'm on the hook for issues. Happy to commit if/when you accept it :)

koobs added a comment.Jun 16 2019, 11:39 AM

I can take you out of Reviewed_by so its clear you didn't :)

danilo accepted this revision.Jun 19 2019, 7:52 PM
This revision is now accepted and ready to land.Jun 19 2019, 7:52 PM
koobs mentioned this in rP505000: editors/nano: Make several port improvements.Jun 24 2019, 3:25 AM
koobs closed this revision.Jul 1 2019, 5:51 AM

Closed by rP505000, I forgot to remove the _ in Differential_Revision

koobs edited the test plan for this revision. (Show Details)Jul 1 2019, 5:53 AM
koobs edited the test plan for this revision. (Show Details)

Revision Contents
Changeset List

PathSize
editors/
nano/
12 lines
6 lines

Diff 58686

View Options

editors/nano/Makefile

Loading...
View Options

editors/nano/distinfo

Loading...