Page MenuHomeFreeBSD

Use UCL for pkg-message
ClosedPublic

Authored by bapt on Feb 23 2019, 6:06 PM.
Tags
None
Referenced Files
F122685913: D19310.id58191.diff
Mon, Jul 7, 11:03 AM
F122664309: D19310.id54361.diff
Mon, Jul 7, 6:55 AM
Unknown Object (File)
Fri, Jul 4, 10:55 AM
Unknown Object (File)
Mon, Jun 23, 3:25 PM
Unknown Object (File)
Sun, Jun 22, 10:27 AM
Unknown Object (File)
Sat, Jun 21, 4:49 AM
Unknown Object (File)
Fri, Jun 20, 8:14 PM
Unknown Object (File)
Fri, Jun 20, 12:46 AM
Subscribers

Details

Reviewers
None
Group Reviewers
portmgr
Commits
rP503385: Use UCL for pkg-message
Summary

Remain backward compatible but use ucl for the pkg-messages, which allows to:

  • append messages one after the other
  • only print message on delete, install, upgrade from a version to another

If pkg-message starts with a [ we consider it should be a valid ucl file

The format is the following:
[
{ message: "Always print" },
{ message: "package being removed", type: remove },
{ message: "package being installed", type: install },
{ message: "package is being upgraded", type: upgrade },
{ message: "Upgrading from lower than 1.0", maximum_version: "1.0", type: upgrade },
{ message: "Upgrading from higher than 1.0", minimum_version: "1.0", type: upgrade },
{ message: "Upgrading from >1.0 < 3.0", maximum_version: "3.0", minimum_version: "1.0",
]

Because it is ucl one can use some sugar like:
[
{ message = <<EOD
formatted
message 'with fancy things'
EOD
},
}

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

  • Remove now useless newlines.
  • This too should be ucl.
  • The file is never empty now, but with no messages, it is ok.
  • Don't use echo flags.
  • Put the deprecation date message with the deprecation message.

pkg 1.11 being out I think we can probably commit that one?

This revision was not accepted when it landed; it landed in state Needs Review.Jun 3 2019, 12:58 PM
Closed by commit rP503385: Use UCL for pkg-message (authored by mat). · Explain Why
This revision was automatically updated to reflect the committed changes.