Differential D20422

audio/audacity: fix build on non-x86
ClosedPublic
Actions

Authored by pkubaj on May 27 2019, 6:00 AM.

Details

Reviewers

linimon
mat
tcberner

Commits

rP503360: audio/audacity: fix build on non-x86

Summary

Audacity by default adds --enable-sse on all architectures, which breaks anything but i386 and amd64. Add SSE option to every architecture, but still enable by default only on amd64 and i386. This will add --disable-sse to CONFIGURE_ARGS, which fixes build.

PR: 238140

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 24528
Build 23319: arc lint + arc unit

Event Timeline

pkubaj created this revision.May 27 2019, 6:00 AM

Harbormaster completed remote builds in B24528: Diff 57939.May 27 2019, 6:00 AM

Looks good to me. Maybe you should think of also marking that option broken on on non x86ish archs.

This revision is now accepted and ready to land.Jun 1 2019, 5:21 PM

In D20422#442424, @tcberner wrote:

Looks good to me. Maybe you should think of also marking that option broken on on non x86ish archs.

There doesn't seem to be a way to an option as broken on everything but two architectures (except for several BROKEN entries, each one for each architecture) so I'm leaving it as is.

Closed by commit rP503360: audio/audacity: fix build on non-x86 (authored by pkubaj). · Explain WhyJun 3 2019, 8:55 AM

This revision was automatically updated to reflect the committed changes.