Page MenuHomeFreeBSD
Differential D19950

[NEW PORT] games/avp: Open source re-implementation of Alien versus Predator
ClosedPublic
Actions

Authored by pkubaj on Apr 18 2019, 9:38 AM.
Tags
None
Referenced Files
F136278805: D19950.id56327.diff
Mon, Nov 17, 12:21 AM
F136264292: D19950.id57358.diff
Sun, Nov 16, 10:38 PM
F136264275: D19950.id57519.diff
Sun, Nov 16, 10:38 PM
F136245100: D19950.id57590.diff
Sun, Nov 16, 8:38 PM
F136237544: D19950.id.diff
Sun, Nov 16, 7:44 PM
F136229599: D19950.id56327.diff
Sun, Nov 16, 6:48 PM
F136206095: D19950.id56331.diff
Sun, Nov 16, 4:14 PM
F136178462: D19950.diff
Sun, Nov 16, 11:43 AM
View All Files
Subscribers
None

Details

Reviewers
mat
tcberner
linimon
Commits
rP502127: games/avp: open source Alien vs Predator engine reimplementation
Summary

Tested on Poudriere with 10.4-RELEASE and on CURRENT (also played some time on CURRENT).

To run it, you need to rename all the game files to lower-case. You also need to run avp from the game directory (the directory from which you can see avp_huds and avp_rifs subdirs).
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228246

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 24297
Build 23122: arc lint + arc unit

Event Timeline

pkubaj created this revision.Apr 18 2019, 9:38 AM
Harbormaster completed remote builds in B23731: Diff 56327.Apr 18 2019, 9:38 AM
pkubaj updated this revision to Diff 56331.Apr 18 2019, 10:45 AM

Update maintainer.

Harbormaster completed remote builds in B23734: Diff 56331.Apr 18 2019, 10:45 AM
mat added inline comments.Apr 18 2019, 1:05 PM
games/avp/Makefile
17

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

tcberner added a comment.May 12 2019, 10:51 AM

Could you address the Makfile order change raised by mat.

games/avp/pkg-descr
2

^ if you can bloat that somewhat, that would be great. If not, works for me.

pkubaj updated this revision to Diff 57358.May 13 2019, 12:35 PM
pkubaj marked an inline comment as done.

USES are moved now.

pkg-desrc contains so little, because there's no project description on its website:
https://icculus.org/avp/

Harbormaster completed remote builds in B24222: Diff 57358.May 13 2019, 12:35 PM
tcberner added inline comments.May 13 2019, 7:55 PM
games/avp/files/patch-CMakeLists.txt
8

^ this looks hacky. What are you trying to achieve here?

pkubaj added inline comments.May 13 2019, 8:00 PM
games/avp/files/patch-CMakeLists.txt
8

For some reason, SDL is not detected, even though it's installed and can be linked to by avp. Simply removing this is enough for things to work.

mat added inline comments.May 14 2019, 11:20 AM
games/avp/Makefile
21

Instead of setting this, you could change the DISVERSIONSUFFIX with:

EXTRACT_SUFX=   -a1.tar.gz
`
pkubaj updated this revision to Diff 57519.May 18 2019, 3:44 AM

Add EXTRACT_SUFX.

Harbormaster completed remote builds in B24297: Diff 57519.May 18 2019, 3:44 AM
pkubaj marked an inline comment as done.May 18 2019, 3:44 AM
mat accepted this revision.May 20 2019, 1:10 PM
mat added inline comments.
games/avp/pkg-descr
1

pkg-descr should be at least a few lines long.

This revision is now accepted and ready to land.May 20 2019, 1:10 PM
Closed by commit rP502127: games/avp: open source Alien vs Predator engine reimplementation (authored by pkubaj). · Explain WhyMay 20 2019, 5:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
games/
1 line
26 lines
3 lines
21 lines
3 lines

Diff 57519

View Options

games/Makefile

Loading...
View Options

games/avp/

Loading...
View Options

games/avp/Makefile

Loading...
View Options

games/avp/distinfo

Loading...
View Options

games/avp/files/

Loading...
View Options

games/avp/files/patch-CMakeLists.txt

Loading...
View Options

games/avp/pkg-descr

Loading...