The mentioned port is required by another one. Here's a resurrection with its problems fixed (distfiles are no longer missing)
Bug: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=199335
svn command: sudo svn cp 'https://svn0.us-west.freebsd.org/ports/head/devel/py-gitpython/@347470' devel/py-gitpython
Details
Details
- Reviewers
koobs
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Nice work Maxim!
Just for completeness could you (along with considering my inline comments)
- Add the svn copy command you ran to this revisions SUMMARY (using "edit revision")
- Add a link to the Bugzilla Issue this is for in the SUMMARY
I'm assuming you have run this through portlint -AC and poudriere. Normally one would include that output as attachments here, but since this is only a review, please including them in your bugzilla issue if you havent already
| devel/py-gitpython/Makefile | ||
|---|---|---|
| 17 | I couldn't find specific versions for nose/mock mentioned uptream. Where did these versions come from? https://github.com/gitpython-developers/GitPython/blob/master/test-requirements.txt | |
| 18 | Id either explicitly add the following to RUN_DEPENDS: ${PYTHON_PKGNAMEPREFIX}gitdb>=0.6.4:${PORTSDIR}/devel/py-gitdbOR TEST_DEPENDS:= ${RUN_DEPENDS} \
${PYTHON_PKGNAMEPREFIX}nose>=1.3.4:${PORTSDIR}/devel/py-nose \
${PYTHON_PKGNAMEPREFIX}mock>=1.0.1:${PORTSDIR}/devel/py-mockWhich portlint doesnt like | |
| 23 | regression-test: build | |
| devel/py-gitpython/Makefile | ||
|---|---|---|
| 17 | The default standard is to:
In this case the only version requirement specified is: install_requires = ['gitdb >= 0.6.4'] So just set nose and mock to >0 | |
| 18 | This still needs to be addressed | |