Differential D1462

Linuxulator. Small optimization.
ClosedPublic
Actions

Authored by dchagin on Jan 8 2015, 9:54 PM.

Details

Reviewers

trasz

Group Reviewers

Linux Emulation

Commits

rS283454: Avoid unnecessary em zeroing in non-exec path

Summary

Avoid unnecessary em zeroing in non-exec path as it already zeroed by malloc with M_ZERO flag and move zeroing to the proper place in exec path.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dchagin updated this revision to Diff 3056.Jan 8 2015, 9:54 PM

dchagin retitled this revision from to Linuxulator. Small optimization..

dchagin updated this object.

dchagin added a reviewer: Linux Emulation.Jan 9 2015, 7:18 AM

trasz added a subscriber: trasz.Mar 21 2015, 5:20 PM

trasz added inline comments.

sys/compat/linux/linux_emul.c
120 ↗	(On Diff #3056)	Those three were not cleared in the previous version of the code. Why do it now?

dchagin added inline comments.Mar 25 2015, 1:27 PM

sys/compat/linux/linux_emul.c
120 ↗	(On Diff #3056)	because it was a bug, this is the 'exec' case and for newly created process I'm clean previous proc's data.

trasz accepted this revision.Mar 25 2015, 1:43 PM

trasz added a reviewer: trasz.

This revision is now accepted and ready to land.Mar 25 2015, 1:43 PM

Closed by commit rS283454: Avoid unnecessary em zeroing in non-exec path (authored by dchagin). · Explain WhyMay 24 2015, 5:07 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

compat/

linux/

linux_emul.c

9 lines

Diff 5657

View Options

head/sys/compat/linux/linux_emul.c

Linuxulator. Small optimization.ClosedPublicActions