Page MenuHomeFreeBSD
Differential D19820

devel/jech-dht: Update to 0.26.
ClosedPublic
Actions

Authored by rigoletto on Apr 4 2019, 4:30 PM.
Tags
None
Referenced Files
F134006350: D19820.diff
Wed, Oct 29, 11:39 PM
Unknown Object (File)
Tue, Oct 28, 9:22 PM
Unknown Object (File)
Tue, Oct 28, 9:22 PM
Unknown Object (File)
Tue, Oct 28, 9:22 PM
Unknown Object (File)
Tue, Oct 28, 9:22 PM
Unknown Object (File)
Tue, Oct 28, 9:22 PM
Unknown Object (File)
Tue, Oct 28, 4:01 PM
Unknown Object (File)
Fri, Oct 24, 5:05 PM
View All Files
Subscribers
None

Details

Reviewers
mat
tcberner
Commits
rP497937: devel/jech-dht: Update to 0.26.
Summary

PR 234515

  • update to 0.26
  • take maintainership as arranged with the current maintainer.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 23518
Build 22522: arc lint + arc unit

Event Timeline

rigoletto created this revision.Apr 4 2019, 4:30 PM
Harbormaster completed remote builds in B23513: Diff 55804.Apr 4 2019, 4:30 PM
tcberner added inline comments.Apr 4 2019, 5:56 PM
devel/jech-dht/Makefile
19

^ why did you change to inline plist?

rigoletto added inline comments.Apr 4 2019, 6:06 PM
devel/jech-dht/Makefile
19

Too few files and to shut portlint .

tcberner added inline comments.Apr 4 2019, 6:16 PM
devel/jech-dht/Makefile
19

I would keep it in the plist -- to reduce the churn. Porlint isn't a law :)

rigoletto updated this revision to Diff 55810.Apr 4 2019, 6:46 PM
rigoletto marked 2 inline comments as done.

Bring pkg-plist back.

Harbormaster completed remote builds in B23518: Diff 55810.Apr 4 2019, 6:46 PM
rigoletto updated this revision to Diff 55811.Apr 4 2019, 6:48 PM

Now yes, bring pkg-plist back.

Harbormaster completed remote builds in B23519: Diff 55811.Apr 4 2019, 6:48 PM
tcberner accepted this revision.Apr 5 2019, 5:02 AM
This revision is now accepted and ready to land.Apr 5 2019, 5:02 AM
mat added inline comments.Apr 5 2019, 6:02 AM
devel/jech-dht/Makefile
17

Why +=?

24

You cannot write to STAGEDIR before the install phase.

Closed by commit rP497937: devel/jech-dht: Update to 0.26. (authored by rigoletto). · Explain WhyApr 5 2019, 6:27 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
devel/
jech-dht/
15 lines
6 lines
files/
2 lines
109 lines

Diff 55810

View Options

devel/jech-dht/Makefile

Loading...
View Options

devel/jech-dht/distinfo

Loading...
View Options

devel/jech-dht/files/BSDmakefile

Loading...
View Options

devel/jech-dht/files/patch-warns

Loading...
View Options

devel/jech-dht/pkg-plist

Loading...