Page MenuHomeFreeBSD

sysutils/dvdisaster: Update to 0.79.5 and pass maintainership to submitter
ClosedPublic

Authored by kai on Apr 3 2019, 7:52 AM.
Tags
None
Referenced Files
F102752436: D19807.id55765.diff
Sat, Nov 16, 5:06 PM
Unknown Object (File)
Sat, Nov 9, 8:16 AM
Unknown Object (File)
Sat, Nov 9, 8:06 AM
Unknown Object (File)
Sat, Nov 9, 8:06 AM
Unknown Object (File)
Sat, Nov 9, 7:43 AM
Unknown Object (File)
Sep 23 2024, 12:35 AM
Unknown Object (File)
Sep 21 2024, 8:13 PM
Unknown Object (File)
Sep 17 2024, 9:00 PM
Subscribers
None

Details

Summary
  • Switch to GCC as upstream officially supports GCC only (please look at "Test plan" for further details)
  • Add desktop and icon file
  • Add missing library dependencies
  • Add additional documentation that describes how dvdisaster accesses optical drives with FreeBSD
  • Add more information to pkg-message and make it dynamic
  • Remove redundant debug options (please look at "Test plan" for further details)
  • Remove redundant configure script arguments
  • Remove redundant configure target
  • Simplify the makefile targets further by using only option helpers and remove the need for <bsd.port.{pre,post}.mk> (please look at "Test plan" for further details)
  • Fix the license
  • Sort pkg-plist

Changelog (not relevants things (e.g. Solaris, Linux, kudos) were pruned for the sake of brevity):

The most prominent feature of this version is that the multithreaded RS03 codec reached production quality, and all required features have been implemented.

A few things will be added with the next releases:

  • adaptive reading is currently disabled as it does not support RS03 yet and would crash or misbehave on RS03 error correction data
  • a heuristic for an exhaustive re-discovery of RS03 structures in a badly damaged medium is missing in the decoder

But these things should not keep you from using RS03, as the encoder is complete and future decoder enhancements do not affect already created RS03 data.

0.79.4 07-10-2012 (not released)

  • optical drives would only be detected for /dev/pass[0-9] on FreeBSD. Fixed to work with arbitrary /dev/pass numbers.
  • blocked menu selection when any other action is in progress
  • made actions properly shut down (e.g. remove incomplete ecc data) when closing the window or pushing the "Quit" button.
  • changed sources for clean compile on gcc 4.4.3
  • added #include <zlib.h> for libpng 1.5 compatibility
  • introduced internal Image object for unified access to optical media and on disk ISO images; lots of internal changes and fixes due to that
  • added --ignore-iso-size option
  • fixed bug in pngpack
  • added remaining patches for Czech online manual.
  • more comprehensive and unified version information for banner, --version, log window and log file to aid in working on bug reports
  • hardcoded icons to defeat theming
  • changed glib.h include for compatibility with glib 2.32
  • removed Darwin / Mac OS X support
  • synced with dvdisaster 0.72.4 fixes
  • completed RS01 and RS03 specification in the papers subdir

0.79.3 21-11-2010

  • Michael Klein provided Altivec optimization for the RS03 encoder and valuable hints for general RS03 encoding speedup
  • included Debian patches 04-manpage.patch, 06-remove-encoding-from-desktop-file.patch, 07-fix-spelling-errors-in-binaries.patch
  • fixed and documented -n command line options for RS02.
  • reworked configure for current NetBSD release

PR: 236423
Submitted by: Bob Eager
Approved by: (one of the mentors)

Test Plan
  • poudriere (11.2-, 12.0-RELEASE, 13.0-CURRENT@r345355 amd64 + i386) -> OK (tested with DOCS/NLS set to on/off each)
  • portlint -> OK
  • Runtime tests -> OK

Notes for the summary section from above:

  • dvdisaster can still be compiled with CLANG without problems if the configure script is patched (as it is currently done). According to the experience of the future maintainer there might be subtle errors during runtime, because CLANG might optimize some statements out and upstream only supports GCC as official compiler and will ignore problem reports that are related to other compilers.
  • The debug options were removed by the future maintainer because they don't seem useful for end users.
  • The makefile targets were completely static in the original patch and didn't make use of the GNUMakefile. This introduced a minor issue with some files that were missing from some help-menu entries then. Thus I merged the targets from the current version of the makefile with the changes from the submitter. If there are issues with it then it goes on my account.

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 23482
Build 22493: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Apr 6 2019, 8:13 AM
This revision was automatically updated to reflect the committed changes.