Differential D19781

rename nvme_ctrlr_destroy_qpair to nvme_ctrlr_destroy_qpairs
ClosedPublic
Actions

Authored by hordijk_netapp.com on Apr 1 2019, 7:45 PM.

Details

Reviewers

jimharris
imp

Commits

rS347369: rename nvme_ctrlr_destroy_qpair to nvme_ctrlr_destroy_qpairs

Summary

Maintain symmetry with nvme_ctrlr_create_qpairs, making it easier to match
init/uninit scenarios. nvme_ctrlr_create_qpairs creates all qpairs in a single
function call. nvme_ctrlr_destroy_qpairs will now do the same.

This also enables a future change where we can have different CQ/SQ qpair
configurations.

Signed-off-by: John Meneghini <johnm@netapp.com>

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23447
Build 22460: arc lint + arc unit

Event Timeline

hordijk_netapp.com created this revision.Apr 1 2019, 7:45 PM

Harbormaster completed remote builds in B23447: Diff 55694.Apr 1 2019, 7:45 PM

Updating commit description.

Harbormaster completed remote builds in B23536: Diff 55843.Apr 5 2019, 4:48 PM

hordijk_netapp.com edited the summary of this revision. (Show Details)Apr 5 2019, 4:50 PM

This change looks correct to me. Unsure why we need to do it though. Would like to see the follow-on fixes that this depends on, since I'm pretty happy with this if there's some reason to change.

This revision is now accepted and ready to land.Apr 12 2019, 6:49 PM

Closed by commit rS347369: rename nvme_ctrlr_destroy_qpair to nvme_ctrlr_destroy_qpairs (authored by imp). · Explain WhyMay 8 2019, 8:18 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

dev/

nvme/

nvme_ctrlr.c

43 lines

Diff 55694

View Options

rename nvme_ctrlr_destroy_qpair to nvme_ctrlr_destroy_qpairsClosedPublicActions