Page MenuHomeFreeBSD

rename nvme_ctrlr_destroy_qpair to nvme_ctrlr_destroy_qpairs
ClosedPublic

Authored by hordijk_netapp.com on Apr 1 2019, 7:45 PM.
Tags
None
Referenced Files
F106871331: D19781.diff
Mon, Jan 6, 5:44 PM
Unknown Object (File)
Fri, Dec 27, 3:17 AM
Unknown Object (File)
Nov 21 2024, 10:10 PM
Unknown Object (File)
Oct 26 2024, 6:04 PM
Unknown Object (File)
Sep 17 2024, 11:19 AM
Unknown Object (File)
Sep 9 2024, 3:09 AM
Unknown Object (File)
Sep 5 2024, 7:05 PM
Unknown Object (File)
Aug 30 2024, 7:40 PM
Subscribers
None

Details

Summary

Maintain symmetry with nvme_ctrlr_create_qpairs, making it easier to match
init/uninit scenarios. nvme_ctrlr_create_qpairs creates all qpairs in a single
function call. nvme_ctrlr_destroy_qpairs will now do the same.

This also enables a future change where we can have different CQ/SQ qpair
configurations.

Signed-off-by: John Meneghini <johnm@netapp.com>

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23447
Build 22460: arc lint + arc unit

Event Timeline

This change looks correct to me. Unsure why we need to do it though. Would like to see the follow-on fixes that this depends on, since I'm pretty happy with this if there's some reason to change.

This revision is now accepted and ready to land.Apr 12 2019, 6:49 PM
This revision was automatically updated to reflect the committed changes.