Page MenuHomeFreeBSD
Differential D19703

sysutils/zol-kmod: clean up
AcceptedPublic
Actions

Authored by jbeich on Mar 25 2019, 7:25 PM.
Tags
None
Referenced Files
F105898623: D19703.diff
Sun, Dec 22, 6:43 AM
Unknown Object (File)
Wed, Dec 4, 5:36 AM
Unknown Object (File)
Sat, Nov 23, 4:10 AM
Unknown Object (File)
Sep 22 2024, 1:22 AM
Unknown Object (File)
Sep 20 2024, 1:51 PM
Unknown Object (File)
Sep 5 2024, 5:09 PM
Unknown Object (File)
Sep 1 2024, 7:15 PM
Unknown Object (File)
Aug 17 2024, 7:50 PM
View All 27 Files
Subscribers
miwi
rene

Details

Reviewers
kmoore
Summary
  • Switch to vendor make targets
  • Embed real Git revision
  • Add license file (for LICENSES_ASK=1 mode)
  • Avoid repetition in GCOV_DESC
  • Convert to option helpers
  • Other minor style
Test Plan

Runtime appears to work fine but I've only tested my ZFS-only setup for a few minutes.

poudriere bulk -t reports:

  • builds fine on 13.0 amd64 and aarch64
  • builds fine with DEBUG=on or GCOV=on

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 23292
Build 22324: arc lint + arc unit

Event Timeline

jbeich created this revision.Mar 25 2019, 7:25 PM
Harbormaster completed remote builds in B23292: Diff 55436.Mar 25 2019, 7:25 PM
jbeich added a subscriber: rene.EditedMar 25 2019, 7:36 PM

@rene, how does USES=kmod:debug work given Mk/bsd.port.mk defines MK_KERNEL_SYMBOLS=no? I'd like to get rid of do-install-DEBUG-on here but the documentation is confusing.

kmoore added a comment.Mar 25 2019, 8:46 PM

Looks pretty good here. I'm fine with a merge once you get an answer on USES=kmod:debug.

Thank you so much for the cleanup on this port!

kmoore accepted this revision.Mar 25 2019, 8:46 PM
This revision is now accepted and ready to land.Mar 25 2019, 8:46 PM

Revision Contents
Changeset List

PathSize
sysutils/
zol-kmod/
43 lines

Diff 55436

View Options

sysutils/zol-kmod/Makefile

Loading...