- Cleanup unnecessary CFLAGS
- Switch shell substitution to $()
- Switch to ImageMagick 7
- s/XORG_WRKDIR/XORG_WRKSRC/ as the variable actually refers WRKSRC
- Use relative path to refer other ports as many other ports do that
Details
Details
- Reviewers
- None
- Commits
- rP495759: net/tigervnc: Switch to options helpers
Diff Detail
Diff Detail
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 23090 Build 22148: arc lint + arc unit
Event Timeline
Comment Actions
If you wanted OPTIONS_SINGLE, it would look like this:
OPTIONS_DEFAULT= IM7 OPTIONS_SINGLE= IMAGEMAGICK OPTIONS_SINGLE_IMAGEMAGICK= IM6 IM7 IMAGEMAGICK_DESC= Imagemagick version for generating [whatever it is it generates here] IM6_DESC= Imagemagick 6 IM7_DESC= Imagemagick 7 IM7_BUILD_DEPENDS= convert:graphics/imagemagick7 IM6_BUILD_DEPENDS= convert:graphics/imagemagick6
| net/tigervnc/Makefile | ||
|---|---|---|
| 45 | This should just be: Similarly, PAM_CMAKE_BOOL= ENABLE_PAM VIEWER_CMAKE_BOOL = BUILD_VIEWER etc. | |
| 66 | bsd.port.options.mk shouldn't be necessary anymore | |
Comment Actions
This seems the port always depends on IM. IM is required only VIEWER option is ON. How can I define nested options?
Comment Actions
Ah, I missed that.
You could use OPTIONS_RADIO instead and do OPTIONS_RADIO= VIEWER, VIEWER_IM7 / VIEWER_IM6. Otherwise I agree here that it's not worth it.
| net/tigervnc/Makefile | ||
|---|---|---|
| 50 | You're missing an E here. | |
Comment Actions
Those changes look good to me! Good work here. I think you're making a good choice to just leave the IM dependency fixed at 7. Do give it some build testing to make sure that CMAKE_BOOL is behaving the way you want it to.