When resetting the controller, we abort I/O. Prior to this fix, we
printed a ton of abort messages for I/O that we're going to
retry. This imparts no useful information. Stop printing them unless
our retry count is exhausted. Clarify code for when we don't retry,
and remove useless arg to a routine that's always called with it
as 'true'.
Details
Details
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| sys/dev/nvme/nvme_qpair.c | ||
|---|---|---|
| 39 ↗ | (On Diff #54627) | Functionally this patch looks fine. I'd probably be more descriptive in the enum names just so they're more clear when used. i.e. ERROR_PRINT_NONE, ERROR_PRINT_NO_MORE_RETRY (or ERROR_PRINT_RETRIES_EXHAUSTED), ERROR_PRINT_ALL. |