postgresql using flavors
Needs ReviewPublic
Actions

Authored by girgen on Feb 8 2019, 12:12 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Aug 7, 7:53 PM

	Unknown Object (File)
	Wed, Jul 30, 3:50 PM

	Unknown Object (File)
	Jun 27 2025, 8:59 AM

	Unknown Object (File)
	Jun 26 2025, 10:07 AM

	Unknown Object (File)
	Jun 22 2025, 1:54 AM

	Unknown Object (File)
	Jun 21 2025, 6:12 PM

	Unknown Object (File)
	Jun 16 2025, 3:52 AM

	Unknown Object (File)
	Jun 1 2025, 12:05 AM

Subscribers

Details

Reviewers

tz
mat

Summary

Use flavors for postgresql-server

Test Plan

test that llvm JIT is in fact used when chosen

Repository

rP FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

Also, could you please remove all whitespace only changes.

databases/postgresql11-server/Makefile
128–139	Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles. Also, as you set `FLAVOR?=`, you can remove the `:U` in the `.if`. Also, move the `*_PKGNAMESUFFIX` out of the `.if`.
195–199	This should probably be using `LLVM_DEFAULT` instead of creating a new LLVM_VERSION.