Page MenuHomeFreeBSD
Differential D19075

Convert bsd.sdl.mk into Uses/sdl.mk
ClosedPublic
Actions

Authored by AMDmi3 on Feb 4 2019, 3:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 18 2024, 12:04 PM
Unknown Object (File)
Feb 18 2024, 2:50 AM
Unknown Object (File)
Dec 28 2023, 6:46 AM
Unknown Object (File)
Dec 23 2023, 2:32 AM
Unknown Object (File)
Dec 23 2023, 2:32 AM
Unknown Object (File)
Dec 21 2023, 5:42 PM
Unknown Object (File)
Dec 20 2023, 1:50 AM
Unknown Object (File)
Nov 13 2023, 6:01 AM
View All 39 Files
Subscribers
mat

Details

Reviewers
None
Group Reviewers
portmgr
O5: Ports Framework(Owns No Changed Paths)
Commits
rP492696: Convert bsd.sdl.mk to Uses/sdl.mk
Summary
  • Convert bsd.sdl.mk into Uses feature
  • Simplify code a bit
Test Plan

Exp-run is needed

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 22353
Build 21528: arc lint + arc unit

Event Timeline

AMDmi3 created this revision.Feb 4 2019, 3:47 PM
mat added a subscriber: mat.Feb 4 2019, 5:12 PM
mat added inline comments.
Mk/Uses/sdl.mk
78

It would probably be a better idea to change this to a DEV_ERROR, and to move it in Mk/bsd.sanity.mk, and to patch the dozen ports or so that use USE_SDL=yes or opt_USE= sdl=yes.

Mk/bsd.port.mk
1426–1429

I was going to suggest fixing those ports too, but there are quite a few.

AMDmi3 added inline comments.Feb 4 2019, 5:47 PM
Mk/Uses/sdl.mk
78

Agreed, already working on this.

AMDmi3 added inline comments.Feb 4 2019, 5:52 PM
Mk/bsd.port.mk
1426–1429

Yep, I'd prefer to convert ports gradually like it's done for USE_GNOME and USE_GL. Number of USE_SDL ports is comparable to USE_GL ports.

mat added inline comments.Feb 5 2019, 1:44 PM
Mk/bsd.port.mk
1426–1429

Well, thing is, having it done gradually is not the nice thing to do, because you end up doing half the job and asking the other ports to finish it :-)

Technically, the way it was done for USE_GNOME or USE_GL was ok, but it was humanly wrong.

AMDmi3 updated this revision to Diff 53604.EditedFeb 5 2019, 5:23 PM
AMDmi3 edited the summary of this revision. (Show Details)

Remove support for USE_SDL=yes (all ports using USE_SDL=yes were fixed)

Owners added a reviewer: O5: Ports Framework.Feb 5 2019, 5:23 PM
Herald added 1 blocking reviewer(s): portmgr. · View Herald TranscriptFeb 5 2019, 5:23 PM
Harbormaster completed remote builds in B22353: Diff 53604.Feb 5 2019, 5:23 PM
AMDmi3 marked an inline comment as done.Feb 5 2019, 7:46 PM
mat added a comment.Feb 6 2019, 8:29 AM

Could you replace all the tests doing:

.if ${foo:Mbar} != ""

with a much simpler:

.if ${foo:Mbar}

and the:

.if ${foo:Mbar} == ""

with:

.if empty(foo:Mbar)

The time when our make required these constructions is long gone.

AMDmi3 updated this revision to Diff 53626.Feb 6 2019, 5:01 PM

Modernize make constructs

Harbormaster completed remote builds in B22365: Diff 53626.Feb 6 2019, 5:01 PM
mat added a comment.Feb 6 2019, 8:46 PM

This look ok to me. Feel free to ask for an exp-run.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 11 2019, 3:21 PM
Closed by commit rP492696: Convert bsd.sdl.mk to Uses/sdl.mk (authored by AMDmi3). · Explain Why
This revision was automatically updated to reflect the committed changes.
AMDmi3 added a comment.Feb 11 2019, 3:23 PM

@mat sorry, I though you've marked this as accepted. Exp-run was OK anyway: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235561

Revision Contents
Changeset List

PathSize
Mk/
Uses/
sdl.mk
bsd.sdl.mk
213 lines
15 lines
4 lines

Diff 53604

View Options

Mk/Uses/sdl.mk

Loading...
View Options

Mk/bsd.port.mk

Loading...
View Options

Mk/bsd.sanity.mk

Loading...
View Options

Mk/bsd.sdl.mk

Loading...