Page MenuHomeFreeBSD
Differential D18796

Change be_mount to mount/unmount child datasets
ClosedPublic
Actions

Authored by jwmaag_gmail.com on Jan 9 2019, 6:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 6, 5:00 PM
Unknown Object (File)
Oct 18 2024, 5:41 AM
Unknown Object (File)
Oct 5 2024, 4:00 AM
Unknown Object (File)
Oct 2 2024, 8:04 PM
Unknown Object (File)
Oct 2 2024, 11:26 AM
Unknown Object (File)
Oct 2 2024, 5:00 AM
Unknown Object (File)
Oct 2 2024, 4:43 AM
Unknown Object (File)
Oct 1 2024, 3:50 PM
View All 88 Files
Subscribers
imp

Details

Reviewers
kevans
Commits
rS342911: libbe(3): Change be_mount to mount/unmount child datasets
Summary

lib/libbe: open the target boot environment and get a zfs
handle, then pass that with the target mountpoint to be_mount_iter;
If the BE_MNT_DEEP flag is set call zfs_iter_filesystems and mount
the child datasets.

similar logic is employed when unmounting the datasets, save for children
are unmounted first.

sbin/bectl: change bectl_cmd_jail to pass the BE_MNT_DEEP flag when
calling be_mount as well as call be_unount when cleaning up after the
jail has exited.

PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234795

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21902
Build 21146: arc lint + arc unit

Event Timeline

jwmaag_gmail.com created this revision.Jan 9 2019, 6:05 PM
Harbormaster completed remote builds in B21898: Diff 52705.Jan 9 2019, 6:05 PM
kevans added a reviewer: kevans.Jan 9 2019, 6:08 PM
jwmaag_gmail.com edited the summary of this revision. (Show Details)Jan 9 2019, 6:27 PM
jwmaag_gmail.com updated this revision to Diff 52709.Jan 9 2019, 6:41 PM

Change bectl_cmd_unjail to call be_unmount instead of unmount

Harbormaster completed remote builds in B21899: Diff 52709.Jan 9 2019, 6:41 PM
kevans added inline comments.Jan 9 2019, 6:54 PM
lib/libbe/be_access.c
71

Small nit while we're here: capitalize the 'c'

80

style(9) nit: these two should be in alphabetical order

85

Space before the opening bracket here

97

style(9) nit: no extra spacing around this strcmp(...) != 0

121

style(9) nit: space after if

124

Might as well return (zfs_iter_filesystems(...)) here

139

Space before the opening brace, and parentheses around the return valuej ust below return (err)

143

Space before the opening brace

242

I think we should set_error on this one

252

Parentheses around the return value

286

Parentheses around the return value

jwmaag_gmail.com updated this revision to Diff 52713.Jan 9 2019, 8:17 PM

fixup style nits

Harbormaster completed remote builds in B21902: Diff 52713.Jan 9 2019, 8:17 PM
kevans added a comment.Jan 9 2019, 10:48 PM

As of r342903, be_mount_iter should be amended to do: mountpoint = be_mountpoint_augmented(info->lbh, zfs_mnt); if we're looking at a mountpoint != none and use mountpoint instead of zfs_mnt in the subsequent snprintf.

We also have an ordering issue with be_umount_iter -- if I have zpool/ROOT/default/usr and mount this to /mnt, we'll currently zfs_iter_filesystems(zpool/ROOT/default) and unmount the first one we hit, which is at /mnt. We can't unmount /mnt until we hit all the children, of course, so it blows up.

jwmaag_gmail.com updated this revision to Diff 52721.Jan 10 2019, 2:46 AM

Use be_mountpoint_augmented to get the mountpoint in case of altroot scenarios.

Harbormaster completed remote builds in B21906: Diff 52721.Jan 10 2019, 2:46 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 10 2019, 3:27 AM
Closed by commit rS342911: libbe(3): Change be_mount to mount/unmount child datasets (authored by kevans). · Explain Why
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptJan 10 2019, 3:27 AM

Revision Contents
Changeset List

PathSize
lib/
libbe/
168 lines
sbin/
bectl/
9 lines

Diff 52713

View Options

lib/libbe/be_access.c

Loading...
View Options

sbin/bectl/bectl_jail.c

Loading...